fix: make scopeSummaries hooks always use main write database#3249
Merged
fix: make scopeSummaries hooks always use main write database#3249
Conversation
gabestein
approved these changes
Mar 3, 2025
Member
gabestein
left a comment
There was a problem hiding this comment.
Code looks good. Seems to work locally. ¯_(ツ)_/¯
Member
Author
|
send it |
gabestein
pushed a commit
that referenced
this pull request
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s) Resolved
Might resolve #3245 ?
Hypothesis: when hooks are run, there might have been enough delay between syncing the write db that we end up reading unsynced data. Instead, we force all
scopeSummaryqueries to read from the master (write) db instead. that way we should be guaranteed to have the correct data.All major write operations which have these hooks should probably run in a transaction instead, but that's quite some more work, and this should have a similar result for now.
https://sequelize.org/docs/v7/other-topics/hooks/#hooks-and-transactions
Test Plan
Screenshots (if applicable)
Optional
Notes/Context/Gotchas
Supporting Docs