Skip to content

chore: improve messaging in func build #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow-robot merged 1 commit into from
Oct 7, 2021
Merged

chore: improve messaging in func build #562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,7 @@ func (c *Client) Build(ctx context.Context, path string) (err error) {

m := []string{
"Still building",
"Don't give up",
"Don't give up on me",
"This is taking a while",
"Still building"}
ticker := time.NewTicker(5 * time.Second)
Expand Down
1 change: 1 addition & 0 deletions cmd/build.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ func runBuild(cmd *cobra.Command, _ []string, clientFn buildClientFn) (err error
}
return
}
fmt.Println("Note: building a Function the first time will take longer than subsequent builds")
}

// We have the registry, so let's use it to derive the Function image name
Expand Down