Skip to content

Comments

chore: improve messaging in func build#562

Merged
knative-prow-robot merged 1 commit intoknative:mainfrom
lance:lance/friendly-build
Oct 7, 2021
Merged

chore: improve messaging in func build#562
knative-prow-robot merged 1 commit intoknative:mainfrom
lance:lance/friendly-build

Conversation

@lance
Copy link
Contributor

@lance lance commented Oct 5, 2021

🐛 make sure the user knows that first builds will take longer.

Fixes: #552

/kind chore

Signed-off-by: Lance Ball lball@redhat.com

Fixes: knative#552

Signed-off-by: Lance Ball <lball@redhat.com>
@lance lance requested a review from zroubalik October 5, 2021 18:52
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 5, 2021
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 5, 2021
@zroubalik
Copy link
Contributor

/approve

1 similar comment
@zroubalik
Copy link
Contributor

/approve

@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance, zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zroubalik
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2021
@knative-prow-robot knative-prow-robot merged commit eccc0ad into knative:main Oct 7, 2021
jrangelramos added a commit to jrangelramos/func that referenced this pull request May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. kind/chore lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make sure users don't kill func build

3 participants