5564: Migrate to Symfony Asset Mapper, drop psalm.xml and admin.css#81
Merged
Merged
Conversation
- Add symfony/asset-mapper bundle with importmap and recipe files - Remove unused psalm.xml (project relies on PHPStan) - Remove obsolete public/css/admin.css Carved out of the closed PR #60 dependency-update scope as a focused PR. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
894fc06 to
27837bc
Compare
API Specification - Non-breaking changesAPI Changelog 1.0.0 vs. 1.0.0No changes detected |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #81 +/- ##
==========================================
Coverage ? 41.63%
Complexity ? 866
==========================================
Files ? 125
Lines ? 2738
Branches ? 0
==========================================
Hits ? 1140
Misses ? 1598
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
turegjorup
added a commit
that referenced
this pull request
May 20, 2026
- Drop asset-mapper migration files (now in PR #81) - Drop duplicate workflows/apispec.yaml (develop has api-spec.yaml) - Consolidate doctrine validation + fixtures into doctrine.yaml, remove duplicates from pr.yaml - Update doctrine.yaml to actions/checkout@v6 and rename job to validate-doctrine-schema - Revert cosmetic changes to .gitignore, .prettierignore, .php-cs-fixer.dist.php, webpack_encore.yaml, .env - Restore psalm.xml and public/css/admin.css (their removal moved to PR #81) - Trim CHANGELOG: drop PR #60 row, fix #90 → #80 link, keep only feature bullets Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
turegjorup
added a commit
that referenced
this pull request
May 20, 2026
The AssetMapper migration moved to PR #81 but the dashboard and base template still referenced AssetMapper, causing every admin smoke test to 500 with "AssetMapper component is not installed". - DashboardController::configureAssets() goes back to addCssFile('css/admin.css') - base.html.twig drops the {{ importmap('app') }} block Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
4 tasks
martinyde
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/dashboard/show#/tickets/showTicket/5564
Description
Focused successor to the closed PR #60. Carves out only the parts of that
dependency-update PR that are still missing from
develop:symfony/asset-mapper ~8.0.0) withimportmap and the recipe-shipped
assets/app.js,assets/styles/app.css,config/packages/asset_mapper.yaml,importmap.phpimportmap:installto theauto-scriptssocomposer installwiresthe importmap automatically
psalm.xml(project relies on PHPStan)public/css/admin.css.gitignore: ignore/public/assets/and/assets/vendor/The rest of PR #60 (Taskfile, workflow split, twig-cs-fixer, markdown lint,
etc.) has already landed on
developthrough later PRs, so it is notincluded here.
Screenshot of the result
No visual changes — Asset Mapper is added alongside Webpack Encore, no
existing assets are switched over in this PR.
Checklist
Additional comments or questions
After this PR is created I'll amend the CHANGELOG entry with the actual PR
number link and force-push.
🤖 Generated with Claude Code