Feature/5566 maintenance contract by martin#80
Open
martinyde wants to merge 52 commits into
Open
Conversation
…roller and styling
…feature/5566_maintenance_contract-
API Specification - Non-breaking changesAPI Changelog 1.0.0 vs. 1.0.0No changes detected |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #80 +/- ##
==========================================
Coverage ? 37.14%
Complexity ? 948
==========================================
Files ? 133
Lines ? 2972
Branches ? 0
==========================================
Hits ? 1104
Misses ? 1868
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Drop asset-mapper migration files (now in PR #81) - Drop duplicate workflows/apispec.yaml (develop has api-spec.yaml) - Consolidate doctrine validation + fixtures into doctrine.yaml, remove duplicates from pr.yaml - Update doctrine.yaml to actions/checkout@v6 and rename job to validate-doctrine-schema - Revert cosmetic changes to .gitignore, .prettierignore, .php-cs-fixer.dist.php, webpack_encore.yaml, .env - Restore psalm.xml and public/css/admin.css (their removal moved to PR #81) - Trim CHANGELOG: drop PR #60 row, fix #90 → #80 link, keep only feature bullets Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- AutoBadgeMenuItem::__call/__callStatic always throw, so return type is `never` — type the magic-method parameters too, ignore unnecessary - AutoBadgeCrudMenuItem::__call delegates to the wrapped CrudMenuItem with an arbitrary method name, so return type is `mixed` - AutoBadgeCrudMenuItem::__callStatic always throws, so return type is `never` - AutoBadgeCrudMenuItem::setBadge uses the wrapped CrudMenuItem's documented union (\Stringable|string|int|float|bool|null); the runtime is_int check is unchanged - Enable reportIgnoresWithoutComments in phpstan.dist.neon so any future @phpstan-ignore must justify itself in a parenthesised comment Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The AssetMapper migration moved to PR #81 but the dashboard and base template still referenced AssetMapper, causing every admin smoke test to 500 with "AssetMapper component is not installed". - DashboardController::configureAssets() goes back to addCssFile('css/admin.css') - base.html.twig drops the {{ importmap('app') }} block Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The template was a global EasyAdmin override that rendered a hardcoded "Notes" fieldset with placeholder text on every entity's detail page. Clearly leftover from local exploration; if notes belong on the SecurityContract detail, add the field via configureFields() instead. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
turegjorup
requested changes
May 20, 2026
Contributor
turegjorup
left a comment
There was a problem hiding this comment.
I have cleaned up some my left over mess here, and made a dedicated PR for switching to asset mapper here: #81
On this PR, we should clean up migrations to just one.
turegjorup
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/ProjectOverview/projectOverview?fromDate=2025-01-01&userIds=14&tab=ticketdetails#/tickets/showTicket/5566
Depends on: #60
Description
Screenshot of the result
List:
Detail:
Checklist
If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.
Additional comments or questions
If you have any further comments or questions for the reviewer please add them here.