Simplifies cross platform installation setup.py#3294
Simplifies cross platform installation setup.py#3294kellyguo11 merged 9 commits intoisaac-sim:mainfrom
Conversation
60c3c4c to
176ae7d
Compare
Mayankm96
left a comment
There was a problem hiding this comment.
Looks good overall.
Mostly wondering why are we enforcing torch via the install script and not the pyproject.toml file. I think back then the motivation was to force install a specific torch version (different from one shipped with IsaacSim). But is this still needed?
I think it'd still be needed if we want to continue support for 4.5. We might also need to do something like this eventually when Isaac Sim removes the pytorch dependency to avoid issues on windows. |
# Description This PR 1. makes sure(skip if already satisfy, else install) the right torch is installed before and after pip installing isaaclab packages as sometime(rare case) due to flaky setup.py and unknown library dependencies changes pytorch version gets overriden. 2. only install pink and retargeters in linux x86 or amd64 machines ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Screenshots Please attach before and after screenshots of the change if applicable. <!-- Example: | Before | After | | ------ | ----- | | _gif/png before_ | _gif/png after_ | To upload images to a PR -- simply drag and drop an image while in edit mode and it should upload the image directly. You can then paste that source into the above before/after sections. --> ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> --------- Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
Description
This PR
makes sure(skip if already satisfy, else install) the right torch is installed before and after pip installing isaaclab packages as sometime(rare case) due to flaky setup.py and unknown library dependencies changes pytorch version gets overriden.
only install pink and retargeters in linux x86 or amd64 machines
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there