Skip to content

Simplifies cross platform installation setup.py#3294

Merged
kellyguo11 merged 9 commits intoisaac-sim:mainfrom
ooctipus:upstream/fix/robust_cross_platform_installation
Sep 3, 2025
Merged

Simplifies cross platform installation setup.py#3294
kellyguo11 merged 9 commits intoisaac-sim:mainfrom
ooctipus:upstream/fix/robust_cross_platform_installation

Conversation

@ooctipus
Copy link
Copy Markdown
Collaborator

Description

This PR

  1. makes sure(skip if already satisfy, else install) the right torch is installed before and after pip installing isaaclab packages as sometime(rare case) due to flaky setup.py and unknown library dependencies changes pytorch version gets overriden.

  2. only install pink and retargeters in linux x86 or amd64 machines

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

Comment thread source/isaaclab/setup.py
Comment thread source/isaaclab/setup.py
@ooctipus ooctipus force-pushed the upstream/fix/robust_cross_platform_installation branch from 60c3c4c to 176ae7d Compare August 28, 2025 22:23
@kellyguo11 kellyguo11 changed the title Upstream/fix/robust cross platform installation Fixes cross platform installation Aug 29, 2025
@Mayankm96 Mayankm96 changed the title Fixes cross platform installation Simplifies cross platform installation setup.py Sep 2, 2025
Copy link
Copy Markdown
Contributor

@Mayankm96 Mayankm96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.

Mostly wondering why are we enforcing torch via the install script and not the pyproject.toml file. I think back then the motivation was to force install a specific torch version (different from one shipped with IsaacSim). But is this still needed?

@kellyguo11
Copy link
Copy Markdown
Contributor

Looks good overall.

Mostly wondering why are we enforcing torch via the install script and not the pyproject.toml file. I think back then the motivation was to force install a specific torch version (different from one shipped with IsaacSim). But is this still needed?

I think it'd still be needed if we want to continue support for 4.5. We might also need to do something like this eventually when Isaac Sim removes the pytorch dependency to avoid issues on windows.

@kellyguo11 kellyguo11 merged commit 2f9298d into isaac-sim:main Sep 3, 2025
8 checks passed
@ooctipus ooctipus deleted the upstream/fix/robust_cross_platform_installation branch October 22, 2025 21:38
george-nehma pushed a commit to george-nehma/DreamLander-IsaacLab that referenced this pull request Oct 24, 2025
# Description

This PR 

1. makes sure(skip if already satisfy, else install) the right torch is
installed before and after pip installing isaaclab packages as
sometime(rare case) due to flaky setup.py and unknown library
dependencies changes pytorch version gets overriden.

2. only install pink and retargeters in linux x86 or amd64 machines


## Type of change

<!-- As you go through the list, delete the ones that are not
applicable. -->

- Bug fix (non-breaking change which fixes an issue)

## Screenshots

Please attach before and after screenshots of the change if applicable.

<!--
Example:

| Before | After |
| ------ | ----- |
| _gif/png before_ | _gif/png after_ |

To upload images to a PR -- simply drag and drop an image while in edit
mode and it should upload the image directly. You can then paste that
source into the above before/after sections.
-->

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there

<!--
As you go through the checklist above, you can mark something as done by
putting an x character in it

For example,
- [x] I have done this task
- [ ] I have not done this task
-->

---------

Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants