Optionally return volume-tag-to-element map from read_gmsh #320
Conversation
|
@inducer, @alexfikl Any ideas how I could appease pylint here? It doesn't seem to like the fact that the result type of |
As far as I know, pylint isn't smart enough to figure this out, so probably best to just add some ignores :\ |
or maybe just confuse it sufficiently...
|
Looks like 5d9dcb9 fixed it, somehow... |
|
Seems like this is the way to go; it's cleaner than anything I've been able to come up with otherwise. In some ways it's unsatisfying, because it sidesteps my sense that if we're tagging surfaces inside the mesh, we ought to be tagging volumes as well; but I haven't been able to find a nice way to integrate that into the current code structure. I guess this approach could still be consistent with that, as long as we think about a given |
|
LGTM, thanks! |
Possibly supersedes #292.