Add volume groups#292
Closed
majosm wants to merge 6 commits into
Closed
Conversation
inducer
reviewed
Apr 4, 2022
| # {{{ volume groups | ||
|
|
||
| @dataclass(frozen=True) | ||
| class VolumeGroup: |
Owner
There was a problem hiding this comment.
Suggested change
| class VolumeGroup: | |
| class TaggedElementSubgroup: |
?
Or ElementSubgroup?
d4f5130 to
f8ee127
Compare
Collaborator
Author
Collaborator
Author
|
After thinking about this more (and finding some bugs in my implementation) I'm starting to wonder if it would be better to just have |
Owner
I'm liking that idea. |
Collaborator
Author
|
Superseded by #320. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taking another stab at region tagging, since #129 is way out of date.
Still need to implement the mesh partitioning part.