Conversation
|
Steveb-p
approved these changes
Jun 27, 2024
Contributor
There was a problem hiding this comment.
Removing guzzle from library dependencies caused issues for projects in the past (non-Ibexa related, just general remark), so ideally we would communicate it.
You know that some developers fail to realize that they're depending on indirect dependency, and do not declare it on their own.
EDIT: I see this is for 5.x series. Then we can do as we want, I guess. :D
konradoboza
approved these changes
Jun 27, 2024
glye
approved these changes
Jun 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Both "guzzlehttp/guzzle" and "php-http/guzzle6-adapter" are recognized as unused by https://github.com/composer-unused/composer-unused in this package.
For QA:
N/A
Documentation:
N/A