Skip to content

Fix undefined 'input' variable #45895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Cyrilvallez merged 1 commit into from
May 13, 2026
Merged

Fix undefined 'input' variable #45895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/transformers/models/bart/modeling_bart.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,7 +645,7 @@ def forward(
)

# embed positions
positions = self.embed_positions(input, past_key_values_length, position_ids=position_ids)
positions = self.embed_positions(input_ids, past_key_values_length, position_ids=position_ids)

@zucchini-nlp zucchini-nlp May 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need to pass inputs/past-length since we already pre-computed position ids a few lines above

positions = positions.to(inputs_embeds.device)

hidden_states = inputs_embeds + positions
Expand Down
2 changes: 1 addition & 1 deletion src/transformers/models/bigbird_pegasus/modeling_bigbird_pegasus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1820,7 +1820,7 @@ def forward(
)

# embed positions
positions = self.embed_positions(input, past_key_values_length, position_ids=position_ids)
positions = self.embed_positions(input_ids, past_key_values_length, position_ids=position_ids)
positions = positions.to(inputs_embeds.device)

hidden_states = inputs_embeds + positions
Expand Down
2 changes: 1 addition & 1 deletion src/transformers/models/mbart/modeling_mbart.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,7 +727,7 @@ def forward(
)

# embed positions
position_ids = self.embed_positions(input, past_key_values_length, position_ids=position_ids)
position_ids = self.embed_positions(input_ids, past_key_values_length, position_ids=position_ids)

hidden_states = inputs_embeds + position_ids.to(inputs_embeds.device)
hidden_states = self.layernorm_embedding(hidden_states)
Expand Down
2 changes: 1 addition & 1 deletion src/transformers/models/plbart/modeling_plbart.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,7 +577,7 @@ def forward(
)

# embed positions
positions = self.embed_positions(input, past_key_values_length, position_ids=position_ids)
positions = self.embed_positions(input_ids, past_key_values_length, position_ids=position_ids)
positions = positions.to(inputs_embeds.device)

hidden_states = inputs_embeds + positions
Expand Down
2 changes: 1 addition & 1 deletion src/transformers/models/pp_formulanet/modeling_pp_formulanet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -909,7 +909,7 @@ def forward(
)

# embed positions
position_ids = self.embed_positions(input, past_key_values_length, position_ids=position_ids)
position_ids = self.embed_positions(input_ids, past_key_values_length, position_ids=position_ids)

hidden_states = inputs_embeds + position_ids.to(inputs_embeds.device)
hidden_states = self.layernorm_embedding(hidden_states)
Expand Down
Loading