Fix undefined 'input' variable#45895
Merged
Cyrilvallez merged 1 commit intoMay 13, 2026
Merged
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: bart, bigbird_pegasus, mbart, plbart, pp_formulanet |
fullyz
force-pushed
the
fix-undefined-input-variable
branch
from
May 11, 2026 13:58
5bcdb5e to
c28203a
Compare
|
|
||
| # embed positions | ||
| positions = self.embed_positions(input, past_key_values_length, position_ids=position_ids) | ||
| positions = self.embed_positions(input_ids, past_key_values_length, position_ids=position_ids) |
Member
There was a problem hiding this comment.
we don't need to pass inputs/past-length since we already pre-computed position ids a few lines above
Cyrilvallez
approved these changes
May 13, 2026
Cyrilvallez
left a comment
Member
There was a problem hiding this comment.
Woww, indeed a bad typo! Thanks for fixing!
jp1924
pushed a commit
to jp1924/transformers
that referenced
this pull request
May 18, 2026
khushali9
pushed a commit
to khushali9/transformers
that referenced
this pull request
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes
self.embed_positions(input, ...)which references undefined variableinputinstead ofinput_idsin decoderforwardmethods.This was introduced during cache refactoring (#35314, #44330) where the
input = input_idslocal alias was removed but theinputreference was not updated.Currently this works because
position_idsis always provided, making the first argument toembed_positionsunused.Before submitting
Who can review?
@ArthurZucker @Cyrilvallez