Skip to content

Added request reviewers function within GHPullRequest. #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kohsuke merged 1 commit into from
May 1, 2018
Merged

Added request reviewers function within GHPullRequest. #430

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/main/java/org/kohsuke/github/GHPullRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
public class GHPullRequest extends GHIssue {

private static final String COMMENTS_ACTION = "/comments";
private static final String REQUEST_REVIEWERS = "/requested_reviewers";

private String patch_url, diff_url, issue_url;
private GHCommitPointer base;
Expand Down Expand Up @@ -345,6 +346,12 @@ public GHPullRequestReviewComment createReviewComment(String body, String sha, S
.to(getApiRoute() + COMMENTS_ACTION, GHPullRequestReviewComment.class).wrapUp(this);
}

public void requestReviewers(List<GHUser> reviewers) {
return new Requester(root).method("POST")
.with("reviewers", toLogins(reviewers))
Copy link

@markkolich markkolich Apr 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@twcurrie any plans to also support team_reviewers?

https://developer.github.com/v3/pulls/review_requests/#create-a-review-request

Copy link
Author

@twcurrie twcurrie Apr 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, is this a blocker? (Are you even able to merge this?)

Copy link

@markkolich markkolich Apr 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Are you even able to merge this?)

No, I'm simply advocating for team_reviewers — I was going to open my own PR for https://developer.github.com/v3/pulls/review_requests/#create-a-review-request but then I saw this one.

I think we need @kohsuke to review and merge.

.to(getApiRoute() + REQUEST_REVIEWERS)
}

/**
* Merge this pull request.
*
Expand Down