Added request reviewers function within GHPullRequest.#430
Added request reviewers function within GHPullRequest.#430kohsuke merged 1 commit intohub4j:masterfrom
Conversation
|
|
||
| public void requestReviewers(List<GHUser> reviewers) { | ||
| return new Requester(root).method("POST") | ||
| .with("reviewers", toLogins(reviewers)) |
There was a problem hiding this comment.
@twcurrie any plans to also support team_reviewers?
https://developer.github.com/v3/pulls/review_requests/#create-a-review-request
There was a problem hiding this comment.
Sure, is this a blocker? (Are you even able to merge this?)
There was a problem hiding this comment.
(Are you even able to merge this?)
No, I'm simply advocating for team_reviewers — I was going to open my own PR for https://developer.github.com/v3/pulls/review_requests/#create-a-review-request but then I saw this one.
I think we need @kohsuke to review and merge.
|
@kohsuke any chance we can get this merged and released? |
|
Oy, you didn't even bother compiling this before submitting a PR... |
|
how about adding travis or circle to build requests? |
|
I built it locally. Your doc's are good but pretty lacking on contributing guidelines. Unless I missed them? |
|
Yeah I'll add CodeShip. @twcurrie it's no big deal, but the way I noticed it is that the code didn't even compile; no semi-colon at the end, a return statement with a value for a function whose return type is |
|
Oh my, I'm clearly writing too much kotlin nowadays. It did compile in kotlin, but yes, obviously not in java... Thanks for putting together this library - it's been a big help. |
|
and this is why i dislike languages that try and be crafty by letting you omit things like a |
Low hanging fruit: https://developer.github.com/v3/pulls/review_requests/#create-a-review-request