Skip to content

Column pooler2 update#293

Closed
breznak wants to merge 25 commits into
columnPooler2from
columnPooler2-update
Closed

Column pooler2 update#293
breznak wants to merge 25 commits into
columnPooler2from
columnPooler2-update

Conversation

@breznak
Copy link
Copy Markdown
Member

@breznak breznak commented Mar 2, 2019

updates to CP branch

  • merges master (makes this PR a bit messy)
  • uses upstream MNIST experiment
  • small fixes to CP
  • all compiles & runs
    • but I'm unlucky, MNIST score is again ~20% 🤔

@breznak
Copy link
Copy Markdown
Member Author

breznak commented Mar 2, 2019

@ctrl-z-9000-times


namespace nupic {
namespace algorithms {
namespace column_pooler {
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added ns

vector<UInt> inhibitionDimensions_;
vector<UInt> cellDimensions_;
UInt cellsPerInhbitionArea_;
UInt cellsPerInhibitionArea_;
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confusing name/typo

Connections distalConnections;


ColumnPooler() {}; //default constructor, must call initialize to setup properly
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default constructor & initialize()

for(const auto &cell : active.getFlatSparse())
{
// Adapt Proximal Segments
NTA_CHECK(cell < proximalMaxSegment_.size()) << "cell oob! " << cell << " < " << proximalMaxSegment_.size();
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure, but sometimes I may crash here

@ctrl-z-9000-times
Copy link
Copy Markdown
Collaborator

Thanks for working on this @breznak!
I have a few changes on my own branch which I want to merge with your changes when I get the chance, and then I will merge this into the main development branch columnPooler2

@breznak
Copy link
Copy Markdown
Member Author

breznak commented Mar 2, 2019

I have a few changes on my own branch which I want to merge with your changes when I get the chance, and then I will merge this into the main development branch columnPooler2

thanks! This was working ok, but some merge conglict broke between me merging your 2nd push to cp2 branch, and merging master.. I'll be trying to fix that.

@breznak
Copy link
Copy Markdown
Member Author

breznak commented Mar 3, 2019

Thanks for merging this in the main devel branch. Closing.

@breznak breznak closed this Mar 3, 2019
@breznak breznak deleted the columnPooler2-update branch March 3, 2019 08:29
@breznak breznak mentioned this pull request Mar 3, 2019
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants