Connections: adaptSegment make const input,#292
Merged
Conversation
add check for segfault from CP
breznak
commented
Mar 2, 2019
| } | ||
|
|
||
| const vector<Synapse> &Connections::synapsesForSegment(Segment segment) const { | ||
| NTA_ASSERT(segment < segments_.size()) << "Segment out of bounds! " << segment; |
Member
Author
There was a problem hiding this comment.
NTA_CHECK would be ideal, but this is a low-level, performance critical method, so we probably can't afford that luxury.
ctrl-z-9000-times
approved these changes
Mar 2, 2019
Collaborator
ctrl-z-9000-times
left a comment
There was a problem hiding this comment.
This is the kind of PR that's easy to review & merge!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add check for segfault from CP