Remove Vertices and Edges collection classes, use plain arrays instead#195
Merged
clue merged 2 commits intographp:masterfrom Aug 17, 2020
Merged
Remove Vertices and Edges collection classes, use plain arrays instead#195clue merged 2 commits intographp:masterfrom
Vertices and Edges collection classes, use plain arrays instead#195clue merged 2 commits intographp:masterfrom
Conversation
Vertices and `Edges collection classes, use plain arrays insteadVertices and Edges collection classes, use plain arrays instead
llaville
added a commit
to llaville/graph-uml
that referenced
this pull request
Sep 10, 2020
Merged
clue
added a commit
to clue-labs/graphviz
that referenced
this pull request
Jan 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset removes the
VerticesandEdgescollection classes and changes the code to use plain arrays instead. These collection classes (incorrectly named "sets") added some very significant complexity to the code base and bring little value for this package. Some of their methods were specifically designed for specific algorithms, so we'll port these over to graphp/algorithms as appropriate (#119).Builds on top of #188, #185 and others.