Skip to content

Remove Vertex IDs, related mappings etc.#185

Merged
clue merged 1 commit intographp:masterfrom
clue-labs:remove-id
Nov 30, 2019
Merged

Remove Vertex IDs, related mappings etc.#185
clue merged 1 commit intographp:masterfrom
clue-labs:remove-id

Conversation

@clue
Copy link
Member

@clue clue commented Nov 29, 2019 

// old
$vertex = $graph->createVertex(10);

// new
$vertex = $graph->createVertex()->setAttribute('id', 10);

Resolves / closes #131
Builds on top of #183

@clue clue merged commit 7d39fff into graphp:master Nov 30, 2019
@clue clue deleted the remove-id branch November 30, 2019 21:10
@clue clue added this to the v1.0.0 milestone Nov 30, 2019
@clue clue mentioned this pull request Nov 30, 2019
Closed
This was referenced Jan 5, 2020
Merged
Merged
clue added a commit to clue-labs/graphviz that referenced this pull request Jan 8, 2020
@clue
Use id attribute for vertex IDs or assign automatically
2ea74b9 
Refs graphp/graph#185
@clue clue mentioned this pull request Aug 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

BC break maintenance new feature

Projects

None yet

Milestone

v1.0.0

Development

Successfully merging this pull request may close these issues.

Consider dropping Vertex ID

1 participant

@clue