Skip to content

Plugin e2e: fix color picker selector #2017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackw merged 3 commits into from
Aug 7, 2025
Merged

Plugin e2e: fix color picker selector #2017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56c1875
test(plugin-e2e): update goto test as we no longer use networkIdle as…
jackw Aug 7, 2025
67b7c85
fix(plugin-e2e): align colorpicker container selector with e2e-select…
jackw Aug 7, 2025
91cdaeb
revert(plugin-e2e): remove typo
jackw Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/plugin-e2e/src/models/components/ColorPicker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export class ColorPicker extends ComponentBase {

private getContainer(): Locator {
const { grafanaVersion, page, selectors } = this.ctx;
if (gte(grafanaVersion, '11.4.1')) {
if (gte(grafanaVersion, '11.5.0')) {
return page.locator(resolveGrafanaSelector(selectors.components.Portal.container));
}
if (gte(grafanaVersion, '8.7.0')) {
Expand Down
24 changes: 3 additions & 21 deletions packages/plugin-e2e/tests/as-admin-user/page-loading/goto.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,36 +1,18 @@
import { test, expect } from '../../../src';

test.describe('gotoDashboardPage', () => {
test('should not display elements when waitUntil `load` is used', async ({
test('should display elements when waitUntil `load` (default) is used', async ({
gotoDashboardPage,
readProvisionedDashboard,
}) => {
const dashboard = await readProvisionedDashboard({ fileName: 'testdatasource.json' });
const dashboardPage = await gotoDashboardPage({ ...dashboard, waitUntil: 'load' });
await expect(dashboardPage.getPanelByTitle('Table data').locator).toHaveCount(0);
});

test('should not display elements when waitUntil `networkidle` (default) is used', async ({
gotoDashboardPage,
readProvisionedDashboard,
}) => {
const dashboard = await readProvisionedDashboard({ fileName: 'testdatasource.json' });
const dashboardPage = await gotoDashboardPage(dashboard);
const dashboardPage = await gotoDashboardPage({ ...dashboard });
await expect(dashboardPage.getPanelByTitle('Table data').locator).toBeVisible();
});
});

test.describe('gotoPanelEditPage', () => {
test('should not display elements when waitUntil `load` is used', async ({
gotoPanelEditPage,
readProvisionedDashboard,
}) => {
const dashboard = await readProvisionedDashboard({ fileName: 'testdatasource.json' });
const panelEditPage = await gotoPanelEditPage({ dashboard, id: '3', waitUntil: 'load' });
await expect(panelEditPage.panel.locator).toHaveCount(0);
});

test('should not display elements when waitUntil `networkidle` (default) is used', async ({
test('should display elements when waitUntil `load` (default) is used', async ({
gotoPanelEditPage,
readProvisionedDashboard,
}) => {
Expand Down
Loading