Verify safe-output pattern consistency is already complete

[Copilot]

Issue requested extracting inline parsing logic from safe_outputs.go into dedicated parse*Config() functions for add_labels.go, assign_milestone.go, and assign_to_agent.go.

Finding: Already resolved - All three parse functions exist in their respective files:

• parseAddLabelsConfig() in add_labels.go (lines 15-36)
• parseAssignMilestoneConfig() in assign_milestone.go (lines 15-36)
• parseAssignToAgentConfig() in assign_to_agent.go (lines 15-42)

safe_outputs.go contains only function calls at lines 156, 168, 174:

addLabelsConfig := c.parseAddLabelsConfig(outputMap)
assignMilestoneConfig := c.parseAssignMilestoneConfig(outputMap)
assignToAgentConfig := c.parseAssignToAgentConfig(outputMap)

All success criteria met: 27/27 pattern compliance, all tests pass, 93/93 workflows compile.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• https://api.github.com/user
  • Triggering command: /usr/bin/gh gh api user --jq .login -json GO111MODULE ache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE ache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
  • Triggering command: /usr/bin/gh gh api user --jq .login GOPATH GOPROXY ache/go/1.25.0/x64/bin/go GOSUMDB GOWORK /opt/hostedtoolc--show-toplevel go env it/ref/tags/v5 GO111MODULE r: $owner, name: $name) { hasDiscussionsEnabled } } GOINSECURE GOMOD GOMODCACHE ps (http block)
  • Triggering command: /usr/bin/gh gh api user --jq .login -json GO111MODULE c8bb52814efbad31e9f06df539d3452e0da/log.json GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 1/x64/bin/node by/2085bc59c89bcrunc GOMOD GOMODCACHE ache/go/1.25.0/x--log (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

---

This section details on the original issue you should resolve

<issue_title>[plan] Complete safe-output pattern consistency</issue_title>
<issue_description>## Overview

This tracking issue covers refactoring to complete the safe-output pattern across all 27 action types by extracting inline parsing logic from safe_outputs.go into dedicated parse*Config() functions.

Source: Issue #5382

Problem

Currently, 3 of 27 safe-output configurations have their parsing logic embedded inline in safe_outputs.go (lines 156-225, ~70 lines) instead of following the established pattern used by the other 24 files.

Files affected:

• add_labels.go - missing parseAddLabelsConfig()
• assign_milestone.go - missing parseAssignMilestoneConfig()
• assign_to_agent.go - missing parseAssignToAgentConfig()

Goal

Achieve 100% pattern compliance (27/27 files) by extracting inline parsing into dedicated functions, improving maintainability and consistency.

Planned Tasks

1. Extract add-labels parsing logic (#aw_add1labels2345)
2. Extract assign-milestone parsing logic (#aw_mile3stone4567)
3. Extract assign-to-agent parsing logic (#aw_agent5assign678)

Success Criteria

• All 3 parse functions extracted to their respective files
• safe_outputs.go reduced by ~60 lines
• All tests pass (make test-unit)
• Pattern compliance: 27/27 files (100%)
• Generated YAML is byte-for-byte identical

Impact

Risk: LOW | Effort: 2-3 hours | Impact: HIGH

Completes established architectural pattern, improves discoverability, and reduces file size of safe_outputs.go.
Related to #5382

AI generated by Plan Command for #5382

Comments on the Issue (you are @copilot in this section)

• Fixes [plan] Complete safe-output pattern consistency #5426

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.