Skip to content

[plan] Complete safe-output pattern consistency #5426

Description

@github-actions

Overview

This tracking issue covers refactoring to complete the safe-output pattern across all 27 action types by extracting inline parsing logic from safe_outputs.go into dedicated parse*Config() functions.

Source: Issue #5382

Problem

Currently, 3 of 27 safe-output configurations have their parsing logic embedded inline in safe_outputs.go (lines 156-225, ~70 lines) instead of following the established pattern used by the other 24 files.

Files affected:

  • add_labels.go - missing parseAddLabelsConfig()
  • assign_milestone.go - missing parseAssignMilestoneConfig()
  • assign_to_agent.go - missing parseAssignToAgentConfig()

Goal

Achieve 100% pattern compliance (27/27 files) by extracting inline parsing into dedicated functions, improving maintainability and consistency.

Planned Tasks

  1. Extract add-labels parsing logic (#aw_add1labels2345)
  2. Extract assign-milestone parsing logic (#aw_mile3stone4567)
  3. Extract assign-to-agent parsing logic (#aw_agent5assign678)

Success Criteria

  • All 3 parse functions extracted to their respective files
  • safe_outputs.go reduced by ~60 lines
  • All tests pass (make test-unit)
  • Pattern compliance: 27/27 files (100%)
  • Generated YAML is byte-for-byte identical

Impact

Risk: LOW | Effort: 2-3 hours | Impact: HIGH

Completes established architectural pattern, improves discoverability, and reduces file size of safe_outputs.go.
Related to #5382

AI generated by Plan Command for #5382

Metadata

Metadata

Assignees

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions