Skip to content

refactor(parser): extract extractEngineMCPSettings to bring extractEngineConfig under 60-line limit #47009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
Jul 21, 2026
Merged

refactor(parser): extract extractEngineMCPSettings to bring extractEngineConfig under 60-line limit #47009

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7bd0f9a
Initial plan
Copilot Jul 21, 2026
401596a
refactor: extract extractEngineMCPSettings helper to reduce extractEn…
Copilot Jul 21, 2026
d40a8a6
Merge branch 'main' into copilot/lint-monster-refactor-parser-extractor
github-actions[bot] Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 22 additions & 16 deletions pkg/parser/import_field_extractor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,22 +321,7 @@ func (acc *importAccumulator) extractEngineConfig(fm map[string]any, fullPath st
// Object engine — extract engine.mcp.* settings first, then decide
// whether to add to engines based on whether an engine ID is present.
if mcpVal, hasMCP := v["mcp"]; hasMCP {
if mcpMap, ok := mcpVal.(map[string]any); ok {
// Extract tool-timeout (first-wins across all imports)
if acc.mergedEngineMCPToolTimeout == "" {
if ttStr, ok := mcpMap["tool-timeout"].(string); ok && ttStr != "" {
acc.mergedEngineMCPToolTimeout = ttStr
parserLog.Printf("Extracted engine.mcp.tool-timeout from import %s: %s", fullPath, ttStr)
}
}
// Extract session-timeout (first-wins across all imports)
if acc.mergedEngineMCPSessionTimeout == "" {
if stStr, ok := mcpMap["session-timeout"].(string); ok && stStr != "" {
acc.mergedEngineMCPSessionTimeout = stStr
parserLog.Printf("Extracted engine.mcp.session-timeout from import %s: %s", fullPath, stStr)
}
}
}
acc.extractEngineMCPSettings(mcpVal, fullPath)
}
// Only add to engines list if this config specifies an actual engine
// (i.e. it carries an 'id' or 'runtime' field). Configs with only
Expand Down Expand Up @@ -367,6 +352,27 @@ func (acc *importAccumulator) extractEngineConfig(fm map[string]any, fullPath st
}
}

// extractEngineMCPSettings extracts engine.mcp.tool-timeout and engine.mcp.session-timeout
// from mcpVal (first-wins across all imports).
func (acc *importAccumulator) extractEngineMCPSettings(mcpVal any, fullPath string) {
mcpMap, ok := mcpVal.(map[string]any)
if !ok {
return
}
if acc.mergedEngineMCPToolTimeout == "" {
if ttStr, ok := mcpMap["tool-timeout"].(string); ok && ttStr != "" {
acc.mergedEngineMCPToolTimeout = ttStr
parserLog.Printf("Extracted engine.mcp.tool-timeout from import %s: %s", fullPath, ttStr)
}
}
if acc.mergedEngineMCPSessionTimeout == "" {
if stStr, ok := mcpMap["session-timeout"].(string); ok && stStr != "" {
acc.mergedEngineMCPSessionTimeout = stStr
parserLog.Printf("Extracted engine.mcp.session-timeout from import %s: %s", fullPath, stStr)
}
}
}

// extractConfigFields extracts scalar and builder-based configuration fields from the
// frontmatter map and writes them into the appropriate accumulator builders and slices.
//
Expand Down
Loading