refactor(parser): extract extractEngineMCPSettings to bring extractEngineConfig under 60-line limit by Copilot · Pull Request #47009 · github/gh-aw

Copilot · 2026-07-21T07:10:20Z

extractEngineConfig in pkg/parser/import_field_extractor.go was 67 lines, exceeding the 60-line custom linter threshold.

Changes

pkg/parser/import_field_extractor.go — pulled the engine MCP timeout extraction block out of extractEngineConfig into a new private helper extractEngineMCPSettings(mcpVal any, fullPath string), reducing extractEngineConfig from 67 → 52 lines with no logic change

// Before: 18-line inline block inside extractEngineConfig
if mcpVal, hasMCP := v["mcp"]; hasMCP {
    if mcpMap, ok := mcpVal.(map[string]any); ok {
        // ... tool-timeout and session-timeout extraction (16 lines) ...
    }
}

// After: delegated to helper
if mcpVal, hasMCP := v["mcp"]; hasMCP {
    acc.extractEngineMCPSettings(mcpVal, fullPath)
}

The new helper encapsulates the first-wins extraction of engine.mcp.tool-timeout and engine.mcp.session-timeout, matching the pattern used by other focused extractors in this file.

Fixes [lint-monster] [Code Quality] Refactor parser extractor long function (1 finding) #46953

Run: https://github.com/github/gh-aw/actions/runs/29813088952

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

pi.dev

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "pi.dev"

See Network Configuration for more information.

Generated by 👨‍🍳 PR Sous Chef · 11 AIC · ⌖ 5.19 AIC · ⊞ 7K · ◷
_{Comment /souschef to run again}

Run: https://github.com/github/gh-aw/actions/runs/29816999996

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

pi.dev

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "pi.dev"

See Network Configuration for more information.

Generated by 👨‍🍳 PR Sous Chef · 12.4 AIC · ⌖ 6.12 AIC · ⊞ 5.5K · ◷
_{Comment /souschef to run again}

…gineConfig length Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot

Pull request overview

Refactors parser engine configuration extraction to satisfy the 60-line linter limit without changing behavior.

Changes:

Extracts MCP timeout handling into extractEngineMCPSettings.
Preserves first-wins semantics for tool and session timeouts.

Show a summary per file

File	Description
`pkg/parser/import_field_extractor.go`	Delegates engine MCP timeout extraction to a focused helper.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 1/1 changed files
Comments generated: 0
Review effort level: Medium

github-actions · 2026-07-21T07:57:58Z

✅ Test Quality Sentinel completed test quality analysis.

No test files were added or modified in this PR. Test Quality Sentinel analysis not required. PR refactors pkg/parser/import_field_extractor.go (22 additions, 16 deletions) to extract extractEngineMCPSettings function—a production-only change.

github-actions · 2026-07-21T07:57:58Z

✅ PR Code Quality Reviewer completed the code quality review.

github-actions · 2026-07-21T07:58:01Z

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

github-actions · 2026-07-21T07:58:02Z

✅ Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR #47009 does not have the 'implementation' label and has only 22 new lines of code in business logic directories (threshold: 100).

github-actions

Clean extract-method refactor. The new extractEngineMCPSettings helper is a faithful extraction of the original inline block — identical logic, same first-wins semantics, proper early return on type mismatch. No issues found.

🔎 Code quality review by PR Code Quality Reviewer · 9.61 AIC · ⌖ 4.33 AIC · ⊞ 5.6K
_{Comment /review to run again}

github-actions

Skills-Based Review 🧠

Applied /codebase-design — this is a clean, focused extraction with no logic change.

✅ Helper is correctly scoped as a method on importAccumulator, consistent with adjacent extractors
✅ Early-return guard for the type assertion replaces the nested if ok — slightly cleaner
✅ extractEngineConfig now sits comfortably under the 60-line limit

Nothing actionable to flag. LGTM.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · 12.2 AIC · ⌖ 4.37 AIC · ⊞ 6.7K
_{Comment /matt to run again}

github-actions

LGTM. Clean, behavior-preserving extraction of extractEngineMCPSettings. Logic, first-wins semantics, and logging are all faithfully preserved.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · 10.7 AIC · ⌖ 4.32 AIC · ⊞ 5K

gh-aw-bot · 2026-07-21T08:15:35Z

@copilot please run the pr-finisher skill, confirm the branch is current after the branch update, address any remaining unresolved review feedback, and summarize the exact next maintainer action to merge this PR.

Run: https://github.com/github/gh-aw/actions/runs/29813088952

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

pi.dev

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "pi.dev"

See Network Configuration for more information.

Generated by 👨‍🍳 PR Sous Chef · 11 AIC · ⌖ 5.19 AIC · ⊞ 7K · ◷
_{Comment /souschef to run again}

Copilot · 2026-07-21T08:30:42Z

@copilot please run the pr-finisher skill, confirm the branch is current after the branch update, address any remaining unresolved review feedback, and summarize the exact next maintainer action to ...

Done. I ran the PR-finisher flow and copilot-review checks.

Branch current after update: confirmed main commit 8070dbd is in this branch (HEAD d40a8a6, merge commit includes 8070dbd as parent).
Remaining unresolved review feedback: none (no unresolved review threads; only informational bot comments).
Local validation: make fmt, make lint, make test-unit, make test, and make recompile all passed.

Exact next maintainer action to merge: re-trigger CI on the current PR HEAD (close/reopen PR, workflow_dispatch, or a maintainer push), then merge once required checks are green.

gh-aw-bot · 2026-07-21T09:16:20Z

@copilot please run the pr-finisher skill, update the branch, rerun CI, and verify this refactor is ready for maintainer review.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

pi.dev

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "pi.dev"

See Network Configuration for more information.

Generated by 👨‍🍳 PR Sous Chef · 12.4 AIC · ⌖ 6.12 AIC · ⊞ 5.5K · ◷
_{Comment /souschef to run again}

Copilot · 2026-07-21T09:29:57Z

@copilot please run the pr-finisher skill, update the branch, rerun CI, and verify this refactor is ready for maintainer review.

...

Completed another pr-finisher pass at d40a8a6 (no code changes were needed).

Branch update/currentness: confirmed up to date with origin/main (8070dbd is an ancestor of HEAD d40a8a6).
Review feedback: no unresolved review threads and no actionable in-scope review comments remain.
Validation: make fmt, make lint, make test-unit, make test, and make recompile all pass locally.

I cannot directly rerun required repository CI from this agent environment. Next maintainer action: re-trigger CI on the current PR HEAD (close/reopen PR, workflow_dispatch, or maintainer push). If required checks pass, this refactor is ready for maintainer review/merge.

Copilot · 2026-07-21T09:34:07Z

@copilot please run the pr-finisher skill, update the branch, rerun CI, and verify this refactor is ready for maintainer review.

...

Branch is already current with main (HEAD d40a8a6, and origin/main is an ancestor; behind count is 0), so no branch-update commit was needed.

I reran the PR-finisher checks for this HEAD:

no unresolved review threads/comments to address
local validation passed: make fmt, make lint, make test-unit, make test, make recompile
prior action_required CI entries had no failed jobs/logged failures; current check snapshot shows 2 copilot runs successful and 1 still in progress

This refactor is ready for maintainer review. If a fresh required-check run is still needed on this exact HEAD, the maintainer can re-trigger CI (close/reopen PR, workflow_dispatch, or maintainer push) and merge once required checks are green.

github-actions · 2026-07-22T16:11:01Z

🎉 This pull request is included in a new release.

Release: v0.83.0

Initial plan

7bd0f9a

Copilot AI assigned Copilot and pelikhan Jul 21, 2026

Copilot AI linked an issue Jul 21, 2026 that may be closed by this pull request

[lint-monster] [Code Quality] Refactor parser extractor long function (1 finding) #46953

Closed

5 tasks

Copilot started work on behalf of pelikhan July 21, 2026 07:10 View session

refactor: extract extractEngineMCPSettings helper to reduce extractEn…

401596a

…gineConfig length Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Refactor extractEngineConfig to meet linter limits~~ refactor(parser): extract extractEngineMCPSettings to bring extractEngineConfig under 60-line limit Jul 21, 2026

Copilot finished work on behalf of pelikhan July 21, 2026 07:21

Copilot AI requested a review from pelikhan July 21, 2026 07:21

pelikhan marked this pull request as ready for review July 21, 2026 07:36

Copilot AI review requested due to automatic review settings July 21, 2026 07:36

Copilot started reviewing on behalf of pelikhan July 21, 2026 07:36 View session

Copilot AI reviewed Jul 21, 2026

View reviewed changes

github-actions Bot approved these changes Jul 21, 2026

View reviewed changes

github-actions Bot mentioned this pull request Jul 21, 2026

[aw] No-Op Runs #43499

Closed

Merge branch 'main' into copilot/lint-monster-refactor-parser-extractor

d40a8a6

github-actions Bot mentioned this pull request Jul 21, 2026

[pr-sous-chef] PR Sous Chef run report #46937

Closed

Copilot started work on behalf of gh-aw-bot July 21, 2026 08:15 View session

Copilot finished work on behalf of gh-aw-bot July 21, 2026 08:31

Copilot AI requested a review from gh-aw-bot July 21, 2026 08:31

Copilot started work on behalf of gh-aw-bot July 21, 2026 09:16 View session

Copilot finished work on behalf of gh-aw-bot July 21, 2026 09:30

Copilot finished work on behalf of gh-aw-bot July 21, 2026 09:34

pelikhan merged commit 4a77d0d into main Jul 21, 2026
26 checks passed

pelikhan deleted the copilot/lint-monster-refactor-parser-extractor branch July 21, 2026 09:49

Uh oh!

Conversation

Copilot AI commented Jul 21, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

github-actions Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Skills-Based Review 🧠

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

gh-aw-bot commented Jul 21, 2026

Uh oh!

Copilot AI commented Jul 21, 2026

Uh oh!

gh-aw-bot commented Jul 21, 2026

Uh oh!

Copilot AI commented Jul 21, 2026

Uh oh!

Copilot AI commented Jul 21, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Jul 21, 2026 •

edited by github-actions Bot

Loading

github-actions Bot commented Jul 21, 2026 •

edited

Loading

github-actions Bot commented Jul 21, 2026 •

edited

Loading

github-actions Bot commented Jul 21, 2026 •

edited

Loading

github-actions Bot commented Jul 21, 2026 •

edited

Loading