Add preconfigured Copilot PAT onboarding in gh aw add-wizard#45987
Conversation
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
🤖 PR Triage
Rationale: DRAFT WIP — only 1 file changed (+7/-2) with a checklist; implementation not yet started. Defer until author completes the work and removes draft status.
|
|
@copilot Revert changes to |
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
gh aw add-wizard
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
|
Hey This PR looks ready for review — it's focused, includes tests, has a clear description, and adds no new dependencies. Nothing blocking here. ✅
|
There was a problem hiding this comment.
Pull request overview
Adds preconfigured Copilot PAT onboarding to add-wizard, alongside several unrelated Git/PR and tooling changes.
Changes:
- Adds PAT URL generation, browser launch, validation, and secret replacement.
- Updates Copilot billing behavior, tests, and documentation.
- Changes PR branch handling and refreshes Serena configuration.
Show a summary per file
| File | Description |
|---|---|
pkg/cli/pr_helpers.go |
Simplifies push error propagation. |
pkg/cli/git.go |
Reuses existing local branches. |
pkg/cli/git_test.go |
Tests branch reuse. |
pkg/cli/engine_secrets.go |
Implements Copilot PAT onboarding and replacement. |
pkg/cli/engine_secrets_test.go |
Tests PAT URL construction. |
pkg/cli/copilot_billing_check.go |
Treats unknown billing states as inconclusive. |
pkg/cli/copilot_billing_check_test.go |
Updates billing-state expectations. |
pkg/cli/bootstrap_profile_runner.go |
Removes browser-disable override. |
pkg/cli/bootstrap_profile_runner_test.go |
Expects browser opening to remain enabled. |
pkg/cli/add_workflow_pr.go |
Filters existing workflows before PR creation. |
pkg/cli/add_workflow_pr_test.go |
Tests workflow filtering and tracking. |
pkg/cli/add_interactive_git.go |
Handles no-PR results. |
pkg/cli/add_interactive_engine.go |
Explicitly selects PAT by default. |
docs/src/content/docs/setup/cli.md |
Documents PAT onboarding. |
docs/src/content/docs/reference/glossary.md |
Updates token glossary entry. |
.serena/project.yml |
Refreshes Serena configuration. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 16/16 changed files
- Comments generated: 6
- Review effort level: Medium
|
@copilot Address all open review comments and run the pr-finisher skill. |
|
@copilot please run the Unresolved review threads:
Failed checks:
|
- Add explicit consent gate before browser open in promptForCopilotPATUnified - Revert unsafe branch reuse: restore createAndSwitchBranch to fail on existing branch - Restore GH_AW_BOOTSTRAP_NO_OPEN_BROWSER env override and parseBootstrapBool - Use constants.CopilotGitHubToken as PAT name in buildCopilotPATCreationURL - Add injectable engineSecretsPromptFn/engineSecretsUploadFn for testability - Add TestEnsureSecretAvailable_CopilotRepromptsWithOverwrite coverage - Revert unrelated filterExistingWorkflowsForPR behavior change in add_workflow_pr Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
|
🎉 This pull request is included in a new release. Release: |
add-wizardnow supports a lower-friction Copilot auth setup when org billing is unavailable: it guides users to a prefilled fine-grained PAT page, accepts token input securely, and preserves strict token-format validation before storingCOPILOT_GITHUB_TOKEN. It also keeps the org-billing path unchanged whencopilot-requestsauth is available.Copilot PAT flow hardening
COPILOT_GITHUB_TOKENCopilot Requestsread permission requestedEchoModePassword) and existinggithub_pat_validation semantics.Advance-consent UX
Docs and contract coverage