Skip to content

[safe-output-integrator] Add missing copilot safe-output fixture files (close-discussion, assign-to-agent, assign-to-user, unassign-from-user)#45004

Merged
pelikhan merged 2 commits into
mainfrom
fix/safe-outputs-fixture-coverage-135a8cc0533de1cd
Jul 12, 2026
Merged

[safe-output-integrator] Add missing copilot safe-output fixture files (close-discussion, assign-to-agent, assign-to-user, unassign-from-user)#45004
pelikhan merged 2 commits into
mainfrom
fix/safe-outputs-fixture-coverage-135a8cc0533de1cd

Conversation

@github-actions

@github-actions github-actions Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds four missing Copilot engine safe-output fixture/test workflow files that were absent from pkg/cli/workflows/. Each file exercises a distinct safe-output type using the copilot engine.

Changes

File Safe-output type Permissions
test-copilot-assign-to-agent.md assign-to-agent contents: read, issues: read
test-copilot-assign-to-user.md assign-to-user contents: read, issues: read
test-copilot-close-discussion.md close-discussion contents: read, discussions: read
test-copilot-unassign-from-user.md unassign-from-user contents: read, issues: read

All four workflows:

  • Trigger: workflow_dispatch
  • Engine: copilot
  • Safe-output max: 1
  • Output format: JSONL via the corresponding safe-output tool

Motivation

The safe-output integrator identified gaps in fixture coverage for these four safe-output types on the Copilot engine. Adding these files brings parity with other engine fixture sets and enables integration testing for assign-to-agent, assign-to-user, close-discussion, and unassign-from-user safe-output paths.

Testing

Each file is a self-contained workflow_dispatch workflow that can be run manually to verify the corresponding safe-output type is accepted and executed correctly by the Copilot engine.

Generated by PR Description Updater for #45004 · 22.3 AIC · ⌖ 4.42 AIC · ⊞ 4.7K ·

Add test fixtures for 4 safe-output types that had no copilot coverage:
- close-discussion
- assign-to-agent
- assign-to-user
- unassign-from-user

These types were already covered in compiler_safe_outputs_config_test.go
but lacked corresponding pkg/cli/workflows/test-copilot-*.md fixtures.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@gh-aw-bot

Copy link
Copy Markdown
Collaborator

pr-sous-chef
@copilot please run the pr-finisher skill, make sure this branch is up to date with its base branch, address any remaining review feedback, and rerun checks when done.

Run: https://github.com/github/gh-aw/actions/runs/29165452899

Generated by 👨‍🍳 PR Sous Chef · 10.7 AIC · ⌖ 7.92 AIC · ⊞ 7.5K ·
Comment /souschef to run again

Copilot AI commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

pr-sous-chef
@copilot please run the pr-finisher skill, make sure this branch is up to date with its base branch, address any remaining review feedback, and rerun checks when done.
...

Done. I ran PR-finisher steps on the current head (48ea409): branch is up to date with main, there are no remaining in-scope review threads/comments to address, and local validation passed (make fmt, make lint, make test-unit, make test, make recompile). The referenced run (29165452899) has no failed jobs. I can’t re-trigger CI from this agent context, so a maintainer will need to re-run checks if needed.

@github-actions

This comment has been minimized.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot please run the pr-finisher skill, address unresolved review comments, and rerun checks once the branch is up to date.

Generated by 👨‍🍳 PR Sous Chef · 4.72 AIC · ⌖ 6.03 AIC · ⊞ 7.5K ·
Comment /souschef to run again

Copilot AI commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

@copilot please run the pr-finisher skill, address unresolved review comments, and rerun checks once the branch is up to date.

...

Completed on current head 48ea409: branch is up to date with main, there are no unresolved in-scope review threads/comments, and checks were rerun locally (make fmt, make lint, make test-unit, make test, make recompile). I also reviewed CI runs/logs (29169609264 and 29169838273) and found no failed jobs. CI re-trigger still requires a maintainer action.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot please run the pr-finisher skill, make sure the branch is up to date with the base branch, and rerun checks once everything is green.

Generated by 👨‍🍳 PR Sous Chef · 12.6 AIC · ⌖ 7.9 AIC · ⊞ 7.5K ·
Comment /souschef to run again

Copilot AI commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

@copilot please run the pr-finisher skill, make sure the branch is up to date with the base branch, and rerun checks once everything is green.

...

Completed PR-finisher pass on 48ea409.

  • Branch is up to date with main (origin/main...HEAD = 0 behind / 1 ahead).
  • No unresolved in-scope review threads/comments were found.
  • Checks rerun locally and passing: make fmt, make lint, make test-unit, make test, make recompile.
  • CI runs/logs reviewed via Actions API: latest completed PR-sous-chef run (29172118147) has no failed jobs.

No code changes were required in this pass, so no new commit was added beyond 48ea409.

CI on this HEAD still needs a maintainer-triggered rerun if required by branch protections.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot please run the pr-finisher skill, address any unresolved review feedback, make sure the branch is up to date with the base branch, and rerun checks.

Generated by 👨‍🍳 PR Sous Chef · 9.19 AIC · ⌖ 8.12 AIC · ⊞ 7.5K ·
Comment /souschef to run again

…ure-coverage-135a8cc0533de1cd

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

@copilot please run the pr-finisher skill, address any unresolved review feedback, make sure the branch is up to date with the base branch, and rerun checks.

...

Done on 0b0b4a9e7e.

  • Branch is now up to date with main (origin/main...HEAD = 0 behind / 2 ahead).
  • No unresolved in-scope review threads/comments were found.
  • Local checks all pass: make fmt, make lint, make test-unit, make test, make recompile.
  • Reviewed latest PR Sous Chef run 29174455499; no failed jobs in logs.

CI for this updated HEAD still requires a maintainer-triggered rerun if branch protections require fresh checks.

@github-actions

Copy link
Copy Markdown
Contributor Author

Hey @github-actions 👋 — great addition! Filling in the four missing test-copilot-*.md fixture files (close-discussion, assign-to-agent, assign-to-user, unassign-from-user) closes an obvious gap in safe-output type coverage under pkg/cli/workflows/.

The PR is focused, well-described, and the added files themselves serve as the test fixtures — this looks ready for review. ✅

Generated by ✅ Contribution Check · 84.2 AIC · ⌖ 11.2 AIC · ⊞ 6.2K ·

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

pr-sous-chef
@copilot please run the pr-finisher skill, address unresolved review comments, and rerun checks once the branch is up to date.

Generated by 👨‍🍳 PR Sous Chef · 8.08 AIC · ⌖ 6.67 AIC · ⊞ 7.5K ·
Comment /souschef to run again

Copilot AI commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

pr-sous-chef
@copilot please run the pr-finisher skill, address unresolved review comments, and rerun checks once the branch is up to date.
...

Completed on 0b0b4a9e7e.

  • Branch is up to date with main (origin/main...HEAD = 0 behind / 2 ahead).
  • No unresolved in-scope review threads/comments were found.
  • Local checks were rerun and passed: make fmt, make lint, make test-unit, make test, make recompile.
  • The referenced PR Sous Chef run 29175664847 completed successfully with no failed jobs.

CI for this HEAD still needs a maintainer-triggered rerun if branch protections require fresh checks.

@pelikhan pelikhan merged commit 966ccb8 into main Jul 12, 2026
1 check passed
@pelikhan pelikhan deleted the fix/safe-outputs-fixture-coverage-135a8cc0533de1cd branch July 12, 2026 07:04
@github-actions

Copy link
Copy Markdown
Contributor Author

🎉 This pull request is included in a new release.

Release: v0.82.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants