This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Fixing the calculation to determine if a line is available for comment#2112
Merged
StanleyGoldman merged 1 commit intomasterfrom Dec 6, 2018
Merged
Fixing the calculation to determine if a line is available for comment#2112StanleyGoldman merged 1 commit intomasterfrom
StanleyGoldman merged 1 commit intomasterfrom
Conversation
jcansdale
approved these changes
Dec 6, 2018
Collaborator
jcansdale
left a comment
There was a problem hiding this comment.
Good catch! I was tempted to add structs for 0-based and 1-based line numbers to prevent them from being compared without conversion. 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2105
Related #2080
Before adding inline annotations, wherever an inline dialog would be is somewhere a comment could be created. After adding inline annotations we had to add code to hide the add comment control if it was not a line that could be commented on. Again a 1-based vs 0-based line numbering scheme bit me.
Fixing the issue and adding more comments.