This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Check Run Annotations should be able to disable the Add Comment functionality#2080
Merged
StanleyGoldman merged 2 commits intofeatures/check-suite-annotations-inlinefrom Nov 26, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request targets #1900
In the diff view, a user can sometimes have annotations that fall outside of the diff lines.
Viewing the annotation presents the user with an "Add comment" box that will always error if the user attempts to add a comment.
CommentThreadViewbut I'm having some trouble. The propertyAvailableForCommentis being set to false, but theCommentThreadViewstill appears.