Rewrite CONTRIBUTING.md to be a guide for new developers on Windows by derrickstolee · Pull Request #1529 · git-for-windows/git

derrickstolee · 2018-03-01T17:15:05Z

Git was originally designed for Unix systems and still today, all the build tools for the Git
codebase assume you have standard Unix tools available in your path. If you have an open-source
mindset and want to start contributing to Git, but primarily use a Windows machine, then you may
have trouble getting started. This guide is for you.

This pull request renames CONTRIBUTING.md to CODE_OF_CONDUCT.md and replaces CONTRIBUTING.md with content that may help new developers working on Git.

The current CONTRIBUTING.md file is actually a code of conduct. This is a valuable document, but is misnamed. A following patch will replace CONTRIBUTING.md with a guide to contributing to Git using a Windows machine. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>

CONTRIBUTING.md

dscho · 2018-03-02T16:37:18Z

Obviously, I like the renaming step, as I suggested it (during informal pre-review). Here is a note to myself that I also have to see whether we need to update any reference to the code of conduct.

Getting started contributing to Git can be difficult on a Windows machine. CONTRIBUTING.md contains a guide to getting started, including detailed steps for setting up build tools, running tests, and submitting patches to upstream. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>

A couple of suggested touchups. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

dscho · 2018-03-06T09:12:45Z

I offered a couple of tiny modifications at derrickstolee#3

@derrickstolee could you have a look?

CONTRIBUTING.md: add guide for first-time contributors

dscho · 2018-03-07T07:41:27Z

Could I ask you to rebase (with --auto-squash)?

Rewrite CONTRIBUTING.md to be a guide for new developers on Windows

derrickstolee force-pushed the contributing branch 2 times, most recently from beb4a65 to f04e4d1 Compare March 1, 2018 17:17

avivey reviewed Mar 1, 2018

View reviewed changes

CONTRIBUTING.md Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

avivey reviewed Mar 1, 2018

View reviewed changes

CONTRIBUTING.md Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

avivey reviewed Mar 1, 2018

View reviewed changes

bbolli reviewed Mar 2, 2018

View reviewed changes

derrickstolee force-pushed the contributing branch from f04e4d1 to c2a2fd5 Compare March 5, 2018 16:04

fixup! CONTRIBUTING.md: add guide for first-time contributors

de2ae42

A couple of suggested touchups. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Merge pull request #3 from dscho/contributing

ef77b24

CONTRIBUTING.md: add guide for first-time contributors

derrickstolee merged commit b34b95c into git-for-windows:master Mar 7, 2018

dscho added a commit that referenced this pull request Mar 23, 2018

Merge pull request #1529 from derrickstolee/contributing

29dcfc1

Rewrite CONTRIBUTING.md to be a guide for new developers on Windows

dscho added a commit that referenced this pull request Apr 3, 2018

Merge pull request #1529 from derrickstolee/contributing

10ad06b

Rewrite CONTRIBUTING.md to be a guide for new developers on Windows

dscho added a commit that referenced this pull request May 29, 2018

Merge pull request #1529 from derrickstolee/contributing

b3c14b8

Rewrite CONTRIBUTING.md to be a guide for new developers on Windows

dscho added a commit that referenced this pull request May 29, 2018

Merge pull request #1529 from derrickstolee/contributing

64bf490

Rewrite CONTRIBUTING.md to be a guide for new developers on Windows

PKRoma pushed a commit to PKRoma/git-for-windows that referenced this pull request Jun 22, 2018

Merge pull request git-for-windows#1529 from derrickstolee/contributing

7e50ceb

Rewrite CONTRIBUTING.md to be a guide for new developers on Windows

PKRoma pushed a commit to PKRoma/git-for-windows that referenced this pull request Jun 22, 2018

Merge pull request git-for-windows#1529 from derrickstolee/contributing

9c0bb61

Rewrite CONTRIBUTING.md to be a guide for new developers on Windows

PKRoma pushed a commit to PKRoma/git-for-windows that referenced this pull request Jun 22, 2018

Merge pull request git-for-windows#1529 from derrickstolee/contributing

131a35c

Rewrite CONTRIBUTING.md to be a guide for new developers on Windows

dscho added a commit that referenced this pull request Aug 22, 2018

Merge pull request #1529 from derrickstolee/contributing

84f5036

Rewrite CONTRIBUTING.md to be a guide for new developers on Windows

dscho added a commit to dscho/git that referenced this pull request Aug 22, 2018

Merge pull request git-for-windows#1529 from derrickstolee/contributing

2b8d569

Rewrite CONTRIBUTING.md to be a guide for new developers on Windows

dscho added a commit that referenced this pull request Aug 23, 2018

Merge pull request #1529 from derrickstolee/contributing

2eeaf42

Rewrite CONTRIBUTING.md to be a guide for new developers on Windows

dscho added a commit that referenced this pull request Aug 23, 2018

Merge pull request #1529 from derrickstolee/contributing

b41d2c2

Rewrite CONTRIBUTING.md to be a guide for new developers on Windows

dscho added a commit that referenced this pull request Aug 23, 2018

Merge pull request #1529 from derrickstolee/contributing

f56578d

Rewrite CONTRIBUTING.md to be a guide for new developers on Windows

jamill pushed a commit to jamill/git that referenced this pull request Aug 28, 2018

Merge pull request git-for-windows#1529 from derrickstolee/contributing

2ab43ee

Rewrite CONTRIBUTING.md to be a guide for new developers on Windows

jamill pushed a commit to jamill/git that referenced this pull request Sep 5, 2018

Merge pull request git-for-windows#1529 from derrickstolee/contributing

67c2d6c

Rewrite CONTRIBUTING.md to be a guide for new developers on Windows

git-for-windows-ci pushed a commit that referenced this pull request Sep 10, 2018

Merge pull request #1529 from derrickstolee/contributing

d6c9b06

Rewrite CONTRIBUTING.md to be a guide for new developers on Windows

jamill pushed a commit to jamill/git that referenced this pull request Sep 11, 2018

Merge pull request git-for-windows#1529 from derrickstolee/contributing

91c9ce2

Rewrite CONTRIBUTING.md to be a guide for new developers on Windows

git-for-windows-ci pushed a commit that referenced this pull request Sep 24, 2018

Merge pull request #1529 from derrickstolee/contributing

d128559

Rewrite CONTRIBUTING.md to be a guide for new developers on Windows

Conversation

derrickstolee commented Mar 1, 2018

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

dscho commented Mar 2, 2018

Uh oh!

dscho commented Mar 6, 2018

Uh oh!

dscho commented Mar 7, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants