Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[extension_google_sign_in_as_googleapis_auth] Update import#3689

Merged
stuartmorgan-g merged 1 commit intoflutter:masterfrom
stuartmorgan-g:googleapis-auth-deprecation
Mar 8, 2021
Merged

[extension_google_sign_in_as_googleapis_auth] Update import#3689
stuartmorgan-g merged 1 commit intoflutter:masterfrom
stuartmorgan-g:googleapis-auth-deprecation

Conversation

@stuartmorgan-g
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g commented Mar 8, 2021

Replaces deprecated import with current version.

Fixes flutter/flutter#77610

Pre-launch Checklist

  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

@stuartmorgan-g
[extension_google_sign_in_as_googleapis_auth] Update import
e1f4c33 
Replaces deprecated import with current version.
@stuartmorgan-g stuartmorgan-g requested a review from ditman March 8, 2021 16:56
@google-cla google-cla bot added the cla: yes label Mar 8, 2021
@stuartmorgan-g stuartmorgan-g mentioned this pull request Mar 8, 2021
Closed
cyanglaz
cyanglaz approved these changes Mar 8, 2021
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stuartmorgan-g stuartmorgan-g added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Mar 8, 2021
@stuartmorgan-g
Copy link
Contributor Author

stuartmorgan-g commented Mar 8, 2021

Landing in advance of the last bot, since various other trees are red on the issue this fixes and I'm confident this won't break just macOS stable.

@stuartmorgan-g stuartmorgan-g merged commit 3acc0cf into flutter:master Mar 8, 2021
@stuartmorgan-g stuartmorgan-g deleted the googleapis-auth-deprecation branch March 8, 2021 18:20
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 8, 2021
@engine-flutter-autoroll
3acc0cf [extension_google_sign_in_as_googleapis_auth] Update import (f…
2c032df 
…lutter/plugins#3689)
@christopherfujino christopherfujino mentioned this pull request Mar 8, 2021
Merged
NickalasB added a commit to NickalasB/plugins that referenced this pull request Mar 8, 2021
@NickalasB
Merge branch 'master' into add_zoom_to_android_webview
fc41c1e 
* master:
  [google_sign_in] fix test(flutter#3690)
  [extension_google_sign_in_as_googleapis_auth] Update import (flutter#3689)
  [google_sign_in] Updates google_sign_in_platform_interfaces adding parametrized `clientId` (flutter#3686)
  Import flutter_test for future compatibility (flutter#3665)
  [ci] Disable analyze on stable for web plugins that contains null safety integration tests.  (flutter#3681)
  Bring HTML inputs into view automatically (flutter#3655)
  [in_app_purchase] presentCodeRedemptionSheet (flutter#3274)
  [google_maps_flutter_web] Downgrade mockito in example app. (flutter#3679)
  Update CI config for Flutter 2 (flutter#3674)
  [image_picker] fix flutter/flutter#71927 (flutter#3676)
  [google_maps_flutter_web] Move integration tests to example. (flutter#3675)
  [google_maps_flutter_web] Make google_maps_flutter_web work with latest plugins  (flutter#3673)

# Conflicts:
#	packages/webview_flutter/CHANGELOG.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ditman ditman Awaiting requested review from ditman

1 more reviewer

@cyanglaz cyanglaz cyanglaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes p: google_sign_in waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

package:googleapis_auth/auth.dart deprecated and shouldn't be used in plugins

2 participants

@stuartmorgan-g @cyanglaz