This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[in_app_purchase] presentCodeRedemptionSheet#3274
Merged
fluttergithubbot merged 25 commits intoflutter:masterfrom Mar 5, 2021
Merged
[in_app_purchase] presentCodeRedemptionSheet#3274fluttergithubbot merged 25 commits intoflutter:masterfrom
fluttergithubbot merged 25 commits intoflutter:masterfrom
Conversation
added 3 commits
January 13, 2021 10:06
…tion-sheet # Conflicts: # .cirrus.yml # packages/in_app_purchase/CHANGELOG.md # packages/in_app_purchase/pubspec.yaml
Member
|
@ABausG why is this drafted? is there anything else you need to do on that PR to get this ready for review? |
…tion-sheet # Conflicts: # packages/in_app_purchase/CHANGELOG.md # packages/in_app_purchase/pubspec.yaml
Contributor
Author
|
@cyanglaz Could you take a look at this? The failing check is because that is running on an image with xcode 11 but the feature is only available with xcode 12. Could you point me to a direction on how I could solve that problem? |
cyanglaz
reviewed
Mar 1, 2021
packages/in_app_purchase/lib/src/store_kit_wrappers/sk_payment_queue_wrapper.dart
Show resolved
Hide resolved
Also add Log message if functionality is unavaible
…tion-sheet # Conflicts: # packages/in_app_purchase/CHANGELOG.md # packages/in_app_purchase/pubspec.yaml
cyanglaz
reviewed
Mar 2, 2021
Contributor
cyanglaz
left a comment
There was a problem hiding this comment.
LGTM % 1 nits. Thanks a lot for the contribution!
packages/in_app_purchase/test/store_kit_wrappers/sk_methodchannel_apis_test.dart
Show resolved
Hide resolved
nt4f04uNd
reviewed
Mar 4, 2021
Comment on lines
+210
to
212
| return Future<void>.sync(() {}); | ||
| } | ||
| return Future<void>.sync(() {}); |
Member
There was a problem hiding this comment.
nit: @cyanglaz i wonder why all over the plugins
Future<void>.sync(() {});is used instead of
Future<void>.value();|
This pull request is not suitable for automatic merging in its current state.
|
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 5, 2021
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 5, 2021
NickalasB
added a commit
to NickalasB/plugins
that referenced
this pull request
Mar 8, 2021
* master: [google_sign_in] fix test(flutter#3690) [extension_google_sign_in_as_googleapis_auth] Update import (flutter#3689) [google_sign_in] Updates google_sign_in_platform_interfaces adding parametrized `clientId` (flutter#3686) Import flutter_test for future compatibility (flutter#3665) [ci] Disable analyze on stable for web plugins that contains null safety integration tests. (flutter#3681) Bring HTML inputs into view automatically (flutter#3655) [in_app_purchase] presentCodeRedemptionSheet (flutter#3274) [google_maps_flutter_web] Downgrade mockito in example app. (flutter#3679) Update CI config for Flutter 2 (flutter#3674) [image_picker] fix flutter/flutter#71927 (flutter#3676) [google_maps_flutter_web] Move integration tests to example. (flutter#3675) [google_maps_flutter_web] Make google_maps_flutter_web work with latest plugins (flutter#3673) # Conflicts: # packages/webview_flutter/CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for
presentCodeRedemptionSheetadded to enable users to redeem subscription offer codes that you generated in App Store Connect.More Info on this can be found here https://developer.apple.com/documentation/storekit/skpaymentqueue/3566726-presentcoderedemptionsheet?language=objc
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?