[google_maps_flutter] Raise `MapUsedAfterWidgetDisposedError` when map controller used after map disposed by filiph · Pull Request #9242 · flutter/packages

filiph · 2025-05-12T13:53:40Z

This change introduces a new MapUsedAfterWidgetDisposedError that facilitates debugging when the user calls a method on GoogleMapsController after the associated map has been disposed. This replaces the previous behavior, which would sometimes throw a Platform-side error (MissingPluginException, Unable to establish connection on channel, etc.).

Although technically non-breaking (we're replacing one error with another), this could be disruptive because the new error is raised eagerly and synchronously, as soon as a call is made. Before, the call could have potentially succeeded (?), and the error was asynchronous (and so, potentially, unawaited and ignored?).

Fixes flutter/flutter#43785.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

filiph · 2025-05-12T14:29:46Z

I was just made aware of #9227, which seems to fix the other aspect of flutter/flutter#43785. Happy to wait with this one until after that one lands.

stuartmorgan-g · 2025-06-24T18:33:42Z

From triage: Still waiting on resolution of #9227 first.

Piinks · 2025-09-02T20:58:18Z

Skipping stale PR nudge per blocked PR. :)

stuartmorgan-g · 2025-09-03T14:21:45Z

Should be unblocked very shortly.

stuartmorgan-g · 2025-09-24T14:33:26Z

This is unblocked now.

FYI, the new file will need a fresh copy of the license header when you merge in main, as the format changed slightly.

filiph · 2025-10-08T08:42:54Z

I've rebased and updated the code. This is now ready for review.

stuartmorgan-g · 2025-10-10T14:25:56Z

packages/google_maps_flutter/google_maps_flutter/lib/src/controller.dart

+/// 1. Set the map controller field to `null` in your widget state's
+///    `dispose()` method, or
+/// 2. Check the [State.mounted] state before each use of the controller.
+class MapUsedAfterWidgetDisposedError extends Error {


Is there a compelling reason to create a new Error type rather than use StateError with the same string used below as its message? A private helper method that returns that state error would still avoid code duplication, but without an extra class.

I thought it nicer to have a separate class at the time, but I'm happy to just use StateError. I'll make the change.

stuartmorgan-g · 2025-10-10T14:26:41Z

packages/google_maps_flutter/google_maps_flutter/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 2.13.2


New API is a minor version bump, per semver.

…exception-43785

filiph · 2025-10-23T09:12:11Z

Sorry for the delay. The custom error class is gone and I bumped to 2.14.0

stuartmorgan-g

LGTM

stuartmorgan-g · 2025-11-04T19:34:25Z

From triage: @filiph is this waiting on anything before it lands?

filiph · 2025-11-04T19:49:29Z

From triage: @filiph is this waiting on anything before it lands?

Not at all! It can land immediately.

* 'main' of https://github.com/CaoGiaHieu-dev/packages: Update packages/go_router/CHANGELOG.md [tool] Remove use of FETCH_HEAD (flutter#10357) Roll Flutter from 027f2e4 to e5d5c01 (73 revisions) (flutter#10362) [camera_platform_interface] Adds support for video stabilization to camera_platform_interface (flutter#10337) [google_maps_flutter] Raise `MapUsedAfterWidgetDisposedError` when map controller used after map disposed (flutter#9242) [pigeon] Replace containsKey with contains in Kotlin generator (flutter#10274) [video_player] Remove `package` in example `AndroidManifest.xml` file (flutter#10245) [flutter_svg] Fixes typo of `allowDrawingOutsideViewBox` in doc comments. (flutter#10256) [in_app_purchase] Remove use of Pigeon's Dart test generator (flutter#10328) [dependabot]: Bump com.squareup.okhttp3:okhttp from 5.1.0 to 5.3.0 in /packages/espresso/android (flutter#10348) Roll Flutter from 6f8abdd to 027f2e4 (26 revisions) (flutter#10335) [google_sign_in] Remove use of OCMock (flutter#10290) [interactive_media_ads] Pin iOS dependency maximum (flutter#10349)

… when map controller used after map disposed (flutter/packages#9242)

flutter/packages@3d926aa...f13bad3 2025-11-06 stuartmorgan@google.com Add Linux CODEOWNERS (flutter/packages#10235) 2025-11-06 stuartmorgan@google.com [ci] Add missing deps (flutter/packages#10366) 2025-11-05 65709676+huanghui1998hhh@users.noreply.github.com [go_router] ShellRoute will merge GoRouter's observers (flutter/packages#9436) 2025-11-05 dgyurov@gmail.com [pigeon] Update analyzer version (flutter/packages#10352) 2025-11-04 stuartmorgan@google.com [tool] Remove use of FETCH_HEAD (flutter/packages#10357) 2025-11-04 engine-flutter-autoroll@skia.org Roll Flutter from 027f2e4 to e5d5c01 (73 revisions) (flutter/packages#10362) 2025-11-04 8490712+ruicraveiro@users.noreply.github.com [camera_platform_interface] Adds support for video stabilization to camera_platform_interface (flutter/packages#10337) 2025-11-04 filiph@users.noreply.github.com [google_maps_flutter] Raise `MapUsedAfterWidgetDisposedError` when map controller used after map disposed (flutter/packages#9242) 2025-11-04 tarrinneal@gmail.com [pigeon] Replace containsKey with contains in Kotlin generator (flutter/packages#10274) 2025-11-04 116356835+AbdeMohlbi@users.noreply.github.com [video_player] Remove `package` in example `AndroidManifest.xml` file (flutter/packages#10245) 2025-11-04 me@nils.re [flutter_svg] Fixes typo of `allowDrawingOutsideViewBox` in doc comments. (flutter/packages#10256) 2025-11-04 stuartmorgan@google.com [in_app_purchase] Remove use of Pigeon's Dart test generator (flutter/packages#10328) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

filiph requested a review from stuartmorgan-g as a code owner May 12, 2025 13:53

github-actions bot added the p: google_maps_flutter label May 12, 2025

filiph force-pushed the fix/missing-plugin-exception-43785 branch from 3b53dc2 to c3eac1e Compare October 8, 2025 07:56

filiph added 7 commits October 9, 2025 08:25

Add guard function

54f9753

Simplify unit test

438ce1f

Bump version and add CHANGELOG

6dbdf3c

Re-apply changes

6f0d63e

Apply correct format

4b5395d

Fix LICENSE header

fb7a11f

Bump version

90ceed1

filiph force-pushed the fix/missing-plugin-exception-43785 branch from 9f01e7a to 90ceed1 Compare October 9, 2025 06:25

stuartmorgan-g requested changes Oct 10, 2025

View reviewed changes

filiph added 5 commits October 22, 2025 15:48

Merge remote-tracking branch 'upstream/main' into fix/missing-plugin-…

33d3973

…exception-43785

Throw a StateError instead of introducing new type

4e64944

Bump minor version

cff40b6

Update test and format

244fec4

Merge remote-tracking branch 'upstream/main' into fix/missing-plugin-…

71cbd5b

…exception-43785

stuartmorgan-g approved these changes Oct 24, 2025

View reviewed changes

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 4, 2025

auto-submit bot merged commit 5cae9ca into flutter:main Nov 4, 2025
80 checks passed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2025

5cae9ca [google_maps_flutter] Raise MapUsedAfterWidgetDisposedError…

b736edb

… when map controller used after map disposed (flutter/packages#9242)

engine-flutter-autoroll mentioned this pull request Nov 5, 2025

Roll Packages from 3d926aa495d3 to 850087bf7e9c (8 revisions) flutter/flutter#178048

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2025

5cae9ca [google_maps_flutter] Raise MapUsedAfterWidgetDisposedError…

b2fb4a9

… when map controller used after map disposed (flutter/packages#9242)

engine-flutter-autoroll mentioned this pull request Nov 5, 2025

Roll Packages from 3d926aa495d3 to b87777caa83f (9 revisions) flutter/flutter#178049

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2025

5cae9ca [google_maps_flutter] Raise MapUsedAfterWidgetDisposedError…

4ec00f7

… when map controller used after map disposed (flutter/packages#9242)

engine-flutter-autoroll mentioned this pull request Nov 5, 2025

Roll Packages from 3d926aa495d3 to 8176ffdbd320 (10 revisions) flutter/flutter#178051

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2025

5cae9ca [google_maps_flutter] Raise MapUsedAfterWidgetDisposedError…

69d41e1

… when map controller used after map disposed (flutter/packages#9242)

engine-flutter-autoroll mentioned this pull request Nov 5, 2025

Roll Packages from 3d926aa495d3 to 8176ffdbd320 (10 revisions) flutter/flutter#178063

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 6, 2025

5cae9ca [google_maps_flutter] Raise MapUsedAfterWidgetDisposedError…

cd796cb

… when map controller used after map disposed (flutter/packages#9242)

engine-flutter-autoroll mentioned this pull request Nov 6, 2025

Roll Packages from 3d926aa495d3 to f13bad3649af (12 revisions) flutter/flutter#178111

Merged

filiph deleted the fix/missing-plugin-exception-43785 branch November 14, 2025 17:53

Conversation

filiph commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

filiph commented May 12, 2025

Uh oh!

stuartmorgan-g commented Jun 24, 2025

Uh oh!

Piinks commented Sep 2, 2025

Uh oh!

stuartmorgan-g commented Sep 3, 2025

Uh oh!

stuartmorgan-g commented Sep 24, 2025

Uh oh!

filiph commented Oct 8, 2025

Uh oh!

stuartmorgan-g Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

filiph Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

filiph Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

filiph Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

filiph commented Oct 23, 2025

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Nov 4, 2025

Uh oh!

filiph commented Nov 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

filiph commented May 12, 2025 •

edited

Loading