[pigeon] Replace containsKey with contains in Kotlin generator by tarrinneal · Pull Request #10274 · flutter/packages

tarrinneal · 2025-10-21T20:50:59Z

gemini-code-assist

Code Review

This pull request correctly replaces the deprecated containsKey with contains in the Kotlin generator. However, it also includes extensive formatting changes across numerous files and languages (Dart, C++, Objective-C, etc.), and adds a large number of new generated test files. Mixing a functional fix with large-scale stylistic changes and new files makes the pull request difficult to review. It is highly recommended to separate these different kinds of changes into distinct pull requests to improve reviewability and maintain a clean version history.

packages/pigeon/example/app/linux/messages.g.h

packages/pigeon/example/app/windows/runner/messages.g.h

script/tool/lib/src/format_command.dart

packages/pigeon/example/app/lib/src/messages.g.dart

packages/pigeon/example/app/linux/messages.g.h

stuartmorgan-g

LGTM

This is a much smaller set of files to review when it's not accidentally reformatting the world :)

* 'main' of https://github.com/CaoGiaHieu-dev/packages: Update packages/go_router/CHANGELOG.md [tool] Remove use of FETCH_HEAD (flutter#10357) Roll Flutter from 027f2e4 to e5d5c01 (73 revisions) (flutter#10362) [camera_platform_interface] Adds support for video stabilization to camera_platform_interface (flutter#10337) [google_maps_flutter] Raise `MapUsedAfterWidgetDisposedError` when map controller used after map disposed (flutter#9242) [pigeon] Replace containsKey with contains in Kotlin generator (flutter#10274) [video_player] Remove `package` in example `AndroidManifest.xml` file (flutter#10245) [flutter_svg] Fixes typo of `allowDrawingOutsideViewBox` in doc comments. (flutter#10256) [in_app_purchase] Remove use of Pigeon's Dart test generator (flutter#10328) [dependabot]: Bump com.squareup.okhttp3:okhttp from 5.1.0 to 5.3.0 in /packages/espresso/android (flutter#10348) Roll Flutter from 6f8abdd to 027f2e4 (26 revisions) (flutter#10335) [google_sign_in] Remove use of OCMock (flutter#10290) [interactive_media_ads] Pin iOS dependency maximum (flutter#10349)

flutter/packages#10274)

flutter/packages@3d926aa...f13bad3 2025-11-06 stuartmorgan@google.com Add Linux CODEOWNERS (flutter/packages#10235) 2025-11-06 stuartmorgan@google.com [ci] Add missing deps (flutter/packages#10366) 2025-11-05 65709676+huanghui1998hhh@users.noreply.github.com [go_router] ShellRoute will merge GoRouter's observers (flutter/packages#9436) 2025-11-05 dgyurov@gmail.com [pigeon] Update analyzer version (flutter/packages#10352) 2025-11-04 stuartmorgan@google.com [tool] Remove use of FETCH_HEAD (flutter/packages#10357) 2025-11-04 engine-flutter-autoroll@skia.org Roll Flutter from 027f2e4 to e5d5c01 (73 revisions) (flutter/packages#10362) 2025-11-04 8490712+ruicraveiro@users.noreply.github.com [camera_platform_interface] Adds support for video stabilization to camera_platform_interface (flutter/packages#10337) 2025-11-04 filiph@users.noreply.github.com [google_maps_flutter] Raise `MapUsedAfterWidgetDisposedError` when map controller used after map disposed (flutter/packages#9242) 2025-11-04 tarrinneal@gmail.com [pigeon] Replace containsKey with contains in Kotlin generator (flutter/packages#10274) 2025-11-04 116356835+AbdeMohlbi@users.noreply.github.com [video_player] Remove `package` in example `AndroidManifest.xml` file (flutter/packages#10245) 2025-11-04 me@nils.re [flutter_svg] Fixes typo of `allowDrawingOutsideViewBox` in doc comments. (flutter/packages#10256) 2025-11-04 stuartmorgan@google.com [in_app_purchase] Remove use of Pigeon's Dart test generator (flutter/packages#10328) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

tarrinneal requested a review from stuartmorgan-g October 21, 2025 20:50

github-actions bot added p: pigeon platform-android platform-ios platform-linux platform-macos platform-windows labels Oct 21, 2025

gemini-code-assist bot reviewed Oct 21, 2025

View reviewed changes

packages/pigeon/example/app/linux/messages.g.h Outdated Show resolved Hide resolved

packages/pigeon/example/app/windows/runner/messages.g.h Outdated Show resolved Hide resolved

github-actions bot removed platform-ios platform-macos labels Oct 21, 2025

stuartmorgan-g requested changes Oct 22, 2025

View reviewed changes

script/tool/lib/src/format_command.dart Outdated Show resolved Hide resolved

packages/pigeon/example/app/lib/src/messages.g.dart Show resolved Hide resolved

packages/pigeon/example/app/linux/messages.g.h Show resolved Hide resolved

stuartmorgan-g changed the title ~~Containskey~~ [pigeon] Replace containsKey with contains in Kotlin generator Oct 22, 2025

tarrinneal force-pushed the containskey branch from 8c40ad6 to 51f8bc5 Compare October 23, 2025 19:12

tarrinneal requested a review from bparrishMines as a code owner October 23, 2025 19:12

github-actions bot added platform-ios p: interactive_media_ads Plugin for IMA SDK and removed platform-linux platform-windows labels Oct 23, 2025

tarrinneal force-pushed the containskey branch from 51f8bc5 to 4367315 Compare October 23, 2025 19:18

github-actions bot removed platform-ios p: interactive_media_ads Plugin for IMA SDK labels Oct 23, 2025

tarrinneal added 2 commits October 23, 2025 16:29

removes containsKey

9b46470

3

2bc9a77

tarrinneal force-pushed the containskey branch from 4367315 to 2bc9a77 Compare October 23, 2025 23:29

tarrinneal added 2 commits October 23, 2025 17:56

test

f13cbd4

gen

dde9f5e

tarrinneal requested a review from stuartmorgan-g October 24, 2025 02:37

stuartmorgan-g approved these changes Oct 24, 2025

View reviewed changes

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 4, 2025

auto-submit bot merged commit 6646deb into flutter:main Nov 4, 2025
80 checks passed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2025

6646deb [pigeon] Replace containsKey with contains in Kotlin generator (

f124774

flutter/packages#10274)

engine-flutter-autoroll mentioned this pull request Nov 5, 2025

Roll Packages from 3d926aa495d3 to 850087bf7e9c (8 revisions) flutter/flutter#178048

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2025

6646deb [pigeon] Replace containsKey with contains in Kotlin generator (

bbf31bc

flutter/packages#10274)

engine-flutter-autoroll mentioned this pull request Nov 5, 2025

Roll Packages from 3d926aa495d3 to b87777caa83f (9 revisions) flutter/flutter#178049

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2025

6646deb [pigeon] Replace containsKey with contains in Kotlin generator (

7375e3c

flutter/packages#10274)

engine-flutter-autoroll mentioned this pull request Nov 5, 2025

Roll Packages from 3d926aa495d3 to 8176ffdbd320 (10 revisions) flutter/flutter#178051

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2025

6646deb [pigeon] Replace containsKey with contains in Kotlin generator (

7f8d091

flutter/packages#10274)

engine-flutter-autoroll mentioned this pull request Nov 5, 2025

Roll Packages from 3d926aa495d3 to 8176ffdbd320 (10 revisions) flutter/flutter#178063

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 6, 2025

6646deb [pigeon] Replace containsKey with contains in Kotlin generator (

57b8287

flutter/packages#10274)

engine-flutter-autoroll mentioned this pull request Nov 6, 2025

Roll Packages from 3d926aa495d3 to f13bad3649af (12 revisions) flutter/flutter#178111

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pigeon] Replace containsKey with contains in Kotlin generator#10274

[pigeon] Replace containsKey with contains in Kotlin generator#10274
auto-submit[bot] merged 4 commits intoflutter:mainfrom
tarrinneal:containskey

tarrinneal commented Oct 21, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g left a comment •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

tarrinneal commented Oct 21, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

stuartmorgan-g left a comment •

edited

Loading