Skip to content

[vector_graphics*] Relax dependency constraints of vector_graphics, vector_graphics_codec, vector_graphics_compiler, flutter_svg #8018

Merged
auto-submit[bot] merged 4 commits intoflutter:mainfrom
jonahwilliams:publish-vg
Nov 5, 2024
Merged

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Nov 4, 2024 •
edited
Loading

Relax the dependency constrraints of the vector graphics packages. Since there are no actual changes to the vector_graphics_codec package and the listed version is already published, I don't think it needs a version bump to remove the publish key.

Fixes flutter/flutter#157626

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on [Discord].

@jonahwilliams jonahwilliams marked this pull request as ready for review November 4, 2024 20:00
stuartmorgan-g
stuartmorgan-g approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

packages/vector_graphics/CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
## 1.1.14

* Relax dependency constraint on vector_graphics_codec.
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relaxes

packages/vector_graphics/pubspec.yaml Outdated
http: ^1.0.0
# See https://github.com/flutter/flutter/issues/157626
vector_graphics_codec: ">=1.1.11+1 <= 1.1.12"
vector_graphics_codec: "^1.1.11+1"
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These shouldn't need quotes once they are using ^.

packages/vector_graphics_compiler/CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
## 1.1.13

* Relax dependency constraint on vector_graphics_codec.
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relaxes

third_party/packages/flutter_svg/CHANGELOG.md Outdated
@@ -1,3 +1,8 @@
## 2.0.12

* Relax the dependency constraints on vector_graphics, vector_graphics_codec,
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relaxes

packages/vector_graphics_compiler/pubspec.yaml Outdated
path_parsing: ^1.0.1
# See https://github.com/flutter/flutter/issues/157626
vector_graphics_codec: ">=1.1.11+1 <= 1.1.12"
vector_graphics_codec: "^1.1.11+1"
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for quotes

third_party/packages/flutter_svg/pubspec.yaml Outdated
vector_graphics_compiler: ">=1.1.11+1 <= 1.1.12"
vector_graphics: "^1.1.11+1"
vector_graphics_codec: "^1.1.11+1"
vector_graphics_compiler: "^1.1.11+1"
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for these.

@stuartmorgan-g stuartmorgan-g added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Nov 4, 2024
@stuartmorgan-g
Copy link
Collaborator

stuartmorgan-g commented Nov 4, 2024

Version/CHANGELOG override: Removing publish_to: none does not require publishing.

@stuartmorgan-g stuartmorgan-g mentioned this pull request Nov 5, 2024
Merged
10 tasks
@stuartmorgan-g
Copy link
Collaborator

stuartmorgan-g commented Nov 5, 2024

I resolved the conflicts and am marking this for autosubmit to unblock the wasm PRs.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 5, 2024
@auto-submit auto-submit bot merged commit 7219431 into flutter:main Nov 5, 2024
@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Nov 5, 2024

Thanks @stuartmorgan !

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 5, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2024
@engine-flutter-autoroll
7219431 [vector_graphics*] Relax dependency constraints of vector_gra…
9b6d1ef 
…phics, vector_graphics_codec, vector_graphics_compiler, flutter_svg (flutter/packages#8018)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 5, 2024
@engine-flutter-autoroll
Roll Packages from 796afa3 to 7219431 (11 revisions) (#158179)
49a16fc 
flutter/packages@796afa3...7219431

2024-11-05 jonahwilliams@google.com [vector_graphics*] Relax dependency constraints of vector_graphics, vector_graphics_codec, vector_graphics_compiler, flutter_svg  (flutter/packages#8018)
2024-11-04 kallentu@google.com [various] Add `missing_code_block_language_in_doc_comment` lint to flutter/packages. (flutter/packages#6473)
2024-11-04 stuartmorgan@google.com [various] Update example apps to Kotlin 1.9.0 (flutter/packages#7998)
2024-11-04 cedvandenbosch@gmail.com [go_router] add current state getter (flutter/packages#7651)
2024-11-04 jessiewong401@gmail.com Applied Gradle Plugins Declaratively for Multiple Plugin Example Apps (flutter/packages#7968)
2024-11-04 engine-flutter-autoroll@skia.org Roll Flutter from f86b777 to 8591d0c (16 revisions) (flutter/packages#8015)
2024-11-04 stuartmorgan@google.com [camera_windows] Revert: Support image streams on Windows platform (flutter/packages#7951)
2024-11-02 stuartmorgan@google.com [camera] Use Pigeon for Windows C++->Dart (flutter/packages#8001)
2024-11-02 kevmoo@users.noreply.github.com [script/tool] update dependencies (flutter/packages#7992)
2024-11-01 engine-flutter-autoroll@skia.org Roll Flutter from 0fe6153 to f86b777 (16 revisions) (flutter/packages#8000)
2024-11-01 kevmoo@users.noreply.github.com [path_parsing] deprecate utility functions that should be private (flutter/packages#7993)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
sinyu1012 added a commit to sinyu1012/packages that referenced this pull request Nov 8, 2024
@sinyu1012
Merge branch 'main' into quick_action/subtitle
3dd729f 
* main: (1187 commits)
  [various] Update example app minSdkVersions (flutter#8035)
  [go_router] Activate leak testing (flutter#7546)
  [in_app_purchase_storekit] Add restore purchases and receipts (flutter#7964)
  [interactive_media_ads] Adds remaining methods for internal wrapper of the Android native `BaseManager` (flutter#7943)
  [google_sign_in/google_identity_services] Clear-up documentation of callbacks in various APIs and uses of those APIs (flutter#8029)
  [flutter_svg] wasm compatibility (flutter#8014)
  Applied Gradle Plugins Declaratively for Multiple Plugin Example Apps (Part 2) (flutter#8019)
  Roll Flutter from 29d40f7 to 73546b3 (20 revisions) (flutter#8028)
  [ci] Upload screenshots, logs, and Xcode test results for drive and integration_test runs (flutter#7430)
  Remove use_modular_headers! from Podfiles (flutter#7796)
  [camera_avfoundation] enable more than 30 fps (flutter#7394)
  Roll Flutter from 8591d0c to 29d40f7 (25 revisions) (flutter#8027)
  [ci] Add vector_graphics and flutter_svg to autolabeler (flutter#8025)
  [vector_graphics_compiler] wasm compatibility (flutter#8021)
  [vector_graphics*] Relax dependency constraints of vector_graphics, vector_graphics_codec, vector_graphics_compiler, flutter_svg  (flutter#8018)
  [various] Add `missing_code_block_language_in_doc_comment` lint to flutter/packages. (flutter#6473)
  [various] Update example apps to Kotlin 1.9.0 (flutter#7998)
  [go_router] add current state getter (flutter#7651)
  Applied Gradle Plugins Declaratively for Multiple Plugin Example Apps (flutter#7968)
  Roll Flutter from f86b777 to 8591d0c (16 revisions) (flutter#8015)
  ...

# Conflicts:
#	packages/quick_actions/quick_actions/CHANGELOG.md
#	packages/quick_actions/quick_actions_ios/CHANGELOG.md
#	packages/quick_actions/quick_actions_platform_interface/CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domesticmouse domesticmouse domesticmouse approved these changes

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[vector_graphics] review package API and publish new versions.

3 participants

@jonahwilliams @stuartmorgan-g @domesticmouse