Remove use_modular_headers! from Podfiles#7796
Remove use_modular_headers! from Podfiles#7796auto-submit[bot] merged 2 commits intoflutter:mainfrom
Conversation
There was a problem hiding this comment.
LGTM once the test passes
Expected: equals [
ProcessCall:"which pod" in /packages,
ProcessCall:"pod lib lint /packages/plugin1/ios/plugin1.podspec --configuration=Debug --skip-tests --use-modular-headers --use-libraries" in /packages,
ProcessCall:"pod lib lint /packages/plugin1/ios/plugin1.podspec --configuration=Debug --skip-tests --use-modular-headers" in /packages
] ordered
Actual: [
ProcessCall:"which pod" in /packages,
ProcessCall:"pod lib lint /packages/plugin1/ios/plugin1.podspec --configuration=Debug --skip-tests --use-libraries" in /packages,
ProcessCall:"pod lib lint /packages/plugin1/ios/plugin1.podspec --configuration=Debug --skip-tests" in /packages
]
Which: at location [1] is ProcessCall:<"pod lib lint /packages/plugin1/ios/plugin1.podspec --configuration=Debug --skip-tests --use-libraries" in /packages> instead of ProcessCall:<"pod lib lint /packages/plugin1/ios/plugin1.podspec --configuration=Debug --skip-tests --use-modular-headers --use-libraries" in /packages>
package:matcher expect
test/podspec_check_command_test.dart 144:7 main.<fn>.<fn>
Could you link to the failing run that led to adding this label? CI should not have flagged this as needing a version change. |
|
@stuartmorgan Ah, I misunderstood the content at the bottom of this section to mean "Add the override label once you've verified your change meets these conditions": https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version I'll update this README to clarify this label should only be added if the CI check fails: flutter/flutter#156342 |
…#156342) Follow-up to flutter/packages#7796 Part of #156259
b8e46b7 to
1b93d46
Compare
LouiseHsu
left a comment
There was a problem hiding this comment.
in_app_purchase, local_auth, and pointer_interceptor lgtm!
|
This is now ready for review! The webview test failure that affected this change was also fixed by flutter/flutter#157449 |
flutter/packages@7219431...bb5a258 2024-11-06 magder@google.com [ci] Upload screenshots, logs, and Xcode test results for drive and integration_test runs (flutter/packages#7430) 2024-11-05 737941+loic-sharma@users.noreply.github.com Remove use_modular_headers! from Podfiles (flutter/packages#7796) 2024-11-05 30872003+misos1@users.noreply.github.com [camera_avfoundation] enable more than 30 fps (flutter/packages#7394) 2024-11-05 engine-flutter-autoroll@skia.org Roll Flutter from 8591d0c to 29d40f7 (25 revisions) (flutter/packages#8027) 2024-11-05 stuartmorgan@google.com [ci] Add vector_graphics and flutter_svg to autolabeler (flutter/packages#8025) 2024-11-05 alex@mariuti.com [vector_graphics_compiler] wasm compatibility (flutter/packages#8021) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
* main: (1187 commits) [various] Update example app minSdkVersions (flutter#8035) [go_router] Activate leak testing (flutter#7546) [in_app_purchase_storekit] Add restore purchases and receipts (flutter#7964) [interactive_media_ads] Adds remaining methods for internal wrapper of the Android native `BaseManager` (flutter#7943) [google_sign_in/google_identity_services] Clear-up documentation of callbacks in various APIs and uses of those APIs (flutter#8029) [flutter_svg] wasm compatibility (flutter#8014) Applied Gradle Plugins Declaratively for Multiple Plugin Example Apps (Part 2) (flutter#8019) Roll Flutter from 29d40f7 to 73546b3 (20 revisions) (flutter#8028) [ci] Upload screenshots, logs, and Xcode test results for drive and integration_test runs (flutter#7430) Remove use_modular_headers! from Podfiles (flutter#7796) [camera_avfoundation] enable more than 30 fps (flutter#7394) Roll Flutter from 8591d0c to 29d40f7 (25 revisions) (flutter#8027) [ci] Add vector_graphics and flutter_svg to autolabeler (flutter#8025) [vector_graphics_compiler] wasm compatibility (flutter#8021) [vector_graphics*] Relax dependency constraints of vector_graphics, vector_graphics_codec, vector_graphics_compiler, flutter_svg (flutter#8018) [various] Add `missing_code_block_language_in_doc_comment` lint to flutter/packages. (flutter#6473) [various] Update example apps to Kotlin 1.9.0 (flutter#7998) [go_router] add current state getter (flutter#7651) Applied Gradle Plugins Declaratively for Multiple Plugin Example Apps (flutter#7968) Roll Flutter from f86b777 to 8591d0c (16 revisions) (flutter#8015) ... # Conflicts: # packages/quick_actions/quick_actions/CHANGELOG.md # packages/quick_actions/quick_actions_ios/CHANGELOG.md # packages/quick_actions/quick_actions_platform_interface/CHANGELOG.md
We added
use_modular_headers!to ourPodfiles as we originally planned to phase outuse_frameworks!(see flutter/flutter#42204). However, our plans have now changed and we are instead phasing out CocoaPods entirely in favor of Swift Package Manager.CocoaPods's
use_frameworks!anduse_modular_headers!are two different overlapping options that should not be used together. This change removes theuse_modular_headers!from example apps'Podfiles. This change does not affect packages themselves.Part of flutter/flutter#156259
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.