Skip to content

[many] Ignore NewerVersionAvailable in android lint #7218

Merged
auto-submit[bot] merged 4 commits intomainfrom
i152316-ignore-newer-version-available
Jul 26, 2024
Merged

[many] Ignore NewerVersionAvailable in android lint #7218
auto-submit[bot] merged 4 commits intomainfrom
i152316-ignore-newer-version-available

Conversation

@reidbaker
Copy link
Contributor

@reidbaker reidbaker commented Jul 25, 2024 •
edited
Loading

  • Updates android lint to ignore NewerVersionAvailable
  • Update changelog

Fixes flutter/flutter#152316

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@reidbaker reidbaker marked this pull request as ready for review July 25, 2024 18:27
stuartmorgan-g
stuartmorgan-g approved these changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 25, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 25, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 25, 2024

auto label is removed for flutter/packages/7218, due to - The status or check suite Linux_android android_device_tests_shard_2 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 25, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 25, 2024

auto label is removed for flutter/packages/7218, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 25, 2024
@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 25, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 25, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 25, 2024

auto label is removed for flutter/packages/7218, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_4 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 25, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 26, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 26, 2024

auto label is removed for flutter/packages/7218, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_4 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 26, 2024
@auto-submit auto-submit bot merged commit 3d358d9 into main Jul 26, 2024
@auto-submit auto-submit bot deleted the i152316-ignore-newer-version-available branch July 26, 2024 14:22
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 26, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 26, 2024
@engine-flutter-autoroll
3d358d9 [many] Ignore NewerVersionAvailable in android lint (flutter/…
b885df0 
…packages#7218)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 26, 2024
@engine-flutter-autoroll
Roll Packages from 19daf6f to 3d358d9 (4 revisions) (#152372)
4b5d24e 
flutter/packages@19daf6f...3d358d9

2024-07-26 reidbaker@google.com [many] Ignore NewerVersionAvailable in android lint  (flutter/packages#7218)
2024-07-25 rexios@rexios.dev [tool] Adds `--wasm` flag to the `drive-examples` command (flutter/packages#7162)
2024-07-25 stuartmorgan@google.com [tool] Add a package-level pre-publish hook (flutter/packages#7156)
2024-07-25 srawlins@google.com [flutter_migrate] Remove one set of parens that wrap a single String literal (flutter/packages#7216)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
@engine-flutter-autoroll @TytaniumDev
Roll Packages from 19daf6f to 3d358d9 (4 revisions) (flutter#152372)
9c770e3 
flutter/packages@19daf6f...3d358d9

2024-07-26 reidbaker@google.com [many] Ignore NewerVersionAvailable in android lint  (flutter/packages#7218)
2024-07-25 rexios@rexios.dev [tool] Adds `--wasm` flag to the `drive-examples` command (flutter/packages#7162)
2024-07-25 stuartmorgan@google.com [tool] Add a package-level pre-publish hook (flutter/packages#7156)
2024-07-25 srawlins@google.com [flutter_migrate] Remove one set of parens that wrap a single String literal (flutter/packages#7216)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@engine-flutter-autoroll @Buchimi
Roll Packages from 19daf6f to 3d358d9 (4 revisions) (flutter#152372)
4ec5d9f 
flutter/packages@19daf6f...3d358d9

2024-07-26 reidbaker@google.com [many] Ignore NewerVersionAvailable in android lint  (flutter/packages#7218)
2024-07-25 rexios@rexios.dev [tool] Adds `--wasm` flag to the `drive-examples` command (flutter/packages#7162)
2024-07-25 stuartmorgan@google.com [tool] Add a package-level pre-publish hook (flutter/packages#7156)
2024-07-25 srawlins@google.com [flutter_migrate] Remove one set of parens that wrap a single String literal (flutter/packages#7216)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@tarrinneal tarrinneal tarrinneal approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines bparrishMines is a code owner

@camsim99 camsim99 Awaiting requested review from camsim99 camsim99 is a code owner

@matanlurey matanlurey Awaiting requested review from matanlurey

@gmackall gmackall Awaiting requested review from gmackall gmackall is a code owner

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: camera p: espresso p: file_selector p: flutter_plugin_android_lifecycle p: google_maps_flutter p: google_sign_in p: image_picker p: in_app_purchase p: local_auth p: path_provider p: pigeon p: quick_actions p: shared_preferences p: url_launcher p: video_player p: webview_flutter platform-android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NewerVersionAvailable gradle lint preventing compilation

3 participants

@reidbaker @stuartmorgan-g @tarrinneal