[tool] Adds --wasm flag to the drive-examples command#7162
[tool] Adds --wasm flag to the drive-examples command#7162auto-submit[bot] merged 6 commits intoflutter:mainfrom
--wasm flag to the drive-examples command#7162Conversation
Currently we have a 1:! correspondence with |
|
@stuartmorgan How about this? |
drive-examples with the web-wasm platform--wasm flag to the drive-examples command
stuartmorgan-g
left a comment
There was a problem hiding this comment.
I'm not familiar with the web args to drive, so @ditman should check that part, but structurally this all LGTM!
ditman
left a comment
There was a problem hiding this comment.
--wasm --web-renderer=canvaskit is some times useful, but not that much for app developers (@eyebrowsoffire said), so this LGTM! Let's land it so we can look at it in the maps migration PR! :)
Do you have any insight on what this combination does? Does it compile the WASM version but run the canvaskit one? |
It compiles the dart code to webassembly but uses the canvaskit renderer. By default, |
flutter/packages@19daf6f...3d358d9 2024-07-26 reidbaker@google.com [many] Ignore NewerVersionAvailable in android lint (flutter/packages#7218) 2024-07-25 rexios@rexios.dev [tool] Adds `--wasm` flag to the `drive-examples` command (flutter/packages#7162) 2024-07-25 stuartmorgan@google.com [tool] Add a package-level pre-publish hook (flutter/packages#7156) 2024-07-25 srawlins@google.com [flutter_migrate] Remove one set of parens that wrap a single String literal (flutter/packages#7216) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@19daf6f...3d358d9 2024-07-26 reidbaker@google.com [many] Ignore NewerVersionAvailable in android lint (flutter/packages#7218) 2024-07-25 rexios@rexios.dev [tool] Adds `--wasm` flag to the `drive-examples` command (flutter/packages#7162) 2024-07-25 stuartmorgan@google.com [tool] Add a package-level pre-publish hook (flutter/packages#7156) 2024-07-25 srawlins@google.com [flutter_migrate] Remove one set of parens that wrap a single String literal (flutter/packages#7216) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@19daf6f...3d358d9 2024-07-26 reidbaker@google.com [many] Ignore NewerVersionAvailable in android lint (flutter/packages#7218) 2024-07-25 rexios@rexios.dev [tool] Adds `--wasm` flag to the `drive-examples` command (flutter/packages#7162) 2024-07-25 stuartmorgan@google.com [tool] Add a package-level pre-publish hook (flutter/packages#7156) 2024-07-25 srawlins@google.com [flutter_migrate] Remove one set of parens that wrap a single String literal (flutter/packages#7216) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
I was unsure if we wanted to add a new platform option for this or add a
--wasmflag to the command. Adding a--wasmflag seems more complicated since we would probably want to add extra handling around proper use of the flag, whereas adding aweb-wasmplatform should require no additional checks.This is in preparation for flutter/flutter#151664