[in_app_purchase_storekit] convert productRequestHandlerTests to swift#7049
Merged
LouiseHsu merged 11 commits intoflutter:mainfrom Jul 16, 2024
Merged
[in_app_purchase_storekit] convert productRequestHandlerTests to swift#7049LouiseHsu merged 11 commits intoflutter:mainfrom
LouiseHsu merged 11 commits intoflutter:mainfrom
Conversation
hellohuanlin
approved these changes
Jul 15, 2024
Contributor
hellohuanlin
left a comment
There was a problem hiding this comment.
LGTM modulo comments
| @@ -0,0 +1 @@ | |||
| /Users/louisehsu/Development/packages/packages/in_app_purchase/in_app_purchase_storekit/example/shared/RunnerTests/ProductRequestHandlerTests.swift No newline at end of file | |||
Contributor
There was a problem hiding this comment.
what is this file? and your username is in the path
|
|
||
| @testable import in_app_purchase_storekit | ||
|
|
||
| class RequestHandlerTest: XCTestCase { |
| let expectation = expectation(description: "Expect response with 1 product") | ||
| var response: SKProductsResponse? | ||
|
|
||
| handler.startProductRequest { r, error in |
Contributor
There was a problem hiding this comment.
nit:
(1) do not use single letter r for variable name
(2) unused error. either use it or use _
Contributor
|
auto label is removed for flutter/packages/7049, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 17, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 17, 2024
flutter/packages@7022a44...d03b1b4 2024-07-16 louisehsu@google.com [in_app_purchase_storekit] convert productRequestHandlerTests to swift (flutter/packages#7049) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
flutter/packages@7022a44...d03b1b4 2024-07-16 louisehsu@google.com [in_app_purchase_storekit] convert productRequestHandlerTests to swift (flutter/packages#7049) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
flutter/packages@7022a44...d03b1b4 2024-07-16 louisehsu@google.com [in_app_purchase_storekit] convert productRequestHandlerTests to swift (flutter/packages#7049) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#151624
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes].///).