[flutter_markdown] Allow for custom block element#5815
Merged
auto-submit[bot] merged 9 commits intoflutter:mainfrom Mar 19, 2024
Merged
[flutter_markdown] Allow for custom block element#5815auto-submit[bot] merged 9 commits intoflutter:mainfrom
auto-submit[bot] merged 9 commits intoflutter:mainfrom
Conversation
domesticmouse
approved these changes
Jan 7, 2024
Contributor
Author
|
@domesticmouse is there any blocker to merge it? |
Contributor
|
PTAL @stuartmorgan |
tarrinneal
requested changes
Feb 21, 2024
tarrinneal
approved these changes
Mar 19, 2024
Contributor
tarrinneal
left a comment
There was a problem hiding this comment.
updated my requests and merged upstream changes
Contributor
|
auto label is removed for flutter/packages/5815, due to - The status or check suite Linux analyze_legacy N-2 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 20, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 20, 2024
flutter/packages@a2f4ce0...23e56af 2024-03-19 43054281+camsim99@users.noreply.github.com [camerax] Update README to encourage users to opt in (flutter/packages#6352) 2024-03-19 dawidope@gmail.com [flutter_markdown] Allow for custom block element (flutter/packages#5815) 2024-03-19 10687576+bparrishMines@users.noreply.github.com [pigeon] Adds Dart implementation of ProxyApi (flutter/packages#6043) 2024-03-19 43054281+camsim99@users.noreply.github.com [camerax] Implements `setFocusMode` (flutter/packages#6176) 2024-03-19 engine-flutter-autoroll@skia.org Roll Flutter from f217fc1 to d31a85b (23 revisions) (flutter/packages#6356) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
|
@dawidope I'm very interested in this feature as well and I have a larger patch that also deals with nested blocks and inheriting styles from parent blocks, I'm interested in collaborating with you to upstream it if you're up for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes problem with adding custom block syntax.
Issue: flutter/flutter#135848
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).