Allow custom blocks to be something other than Column or SizedBox#7859
Allow custom blocks to be something other than Column or SizedBox#7859auto-submit[bot] merged 6 commits intoflutter:mainfrom
Column or SizedBox#7859Conversation
d9e63dc to
d079db0
Compare
stuartmorgan-g
left a comment
There was a problem hiding this comment.
This addresses a customer request.
This looks like it's flutter/flutter#135848 ?
71b8cc2 to
eb68bc0
Compare
|
Okay, I've removed the new API surface, and just kept the fixed implementation of An explanation of the remaining change in In the prior implementation, only a handful of elements get specialized block widgets (e.g., list, table, blockquote, pre, hr, see the conditional statements after the modified code), other block elements and custom blocks will be built as a With the added code, we will visit the custom block element's |
Column or SizedBox
|
I think this does fix the last item in flutter/flutter#135848, referenced in flutter/flutter#135848 (comment), so I marked it as fixing that bug. |
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM with a couple of adjustments to the code (one optional).
c777fcd to
e6ed413
Compare
flutter/packages@b6f7e47...5e03bb1 2024-10-21 43054281+camsim99@users.noreply.github.com [video_player_android] Correct rotation of videos recorded by the camera (flutter/packages#7846) 2024-10-21 gspencergoog@users.noreply.github.com Allow custom blocks to be something other than `Column` or `SizedBox` (flutter/packages#7859) 2024-10-21 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump androidx.annotation:annotation from 1.8.2 to 1.9.0 in /packages/camera/camera_android/android (flutter/packages#7905) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@b6f7e47...5e03bb1 2024-10-21 43054281+camsim99@users.noreply.github.com [video_player_android] Correct rotation of videos recorded by the camera (flutter/packages#7846) 2024-10-21 gspencergoog@users.noreply.github.com Allow custom blocks to be something other than `Column` or `SizedBox` (flutter/packages#7859) 2024-10-21 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump androidx.annotation:annotation from 1.8.2 to 1.9.0 in /packages/camera/camera_android/android (flutter/packages#7905) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Description
This adds support for allowing block tags recognized by the Markdown processor to insert something other than just a
Columnor aSizedBox(the defaults for blocks with children, and without). Without this ability, custom builders can't insert their own widgets to, say, make it be a colored container instead.This addresses a customer request.
Fixes flutter/flutter#135848