[css_colors] Adopt code excerpts in README#5478
[css_colors] Adopt code excerpts in README#5478auto-submit[bot] merged 6 commits intoflutter:mainfrom
Conversation
tarrinneal
left a comment
There was a problem hiding this comment.
lgtm with a nit. @stuartmorgan for second review.
packages/css_colors/CHANGELOG.md
Outdated
| ## 1.1.4 | ||
|
|
||
| * Updates minimum supported SDK version to Flutter 3.10/Dart 3.0. | ||
| * Updates README to improve example of using `CSSColors`. |
There was a problem hiding this comment.
Improves README example and updates it to use code excerpts.
There was a problem hiding this comment.
It would be really easy for us to get this from an actual example main.dart rather than having to maintain a second file. I think it'll also be pretty confusing to have the example directory and pubspec and such, but not actually have an example to run.
Given that, I think we should either wait for #5512, or fold creating an actual example into this PR.
There was a problem hiding this comment.
Alternately, we could do this with test/, since looking at the other PR I'm not sure we actually want an example.
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM with nit, thanks!
packages/css_colors/README.md
Outdated
| @@ -8,13 +8,15 @@ from `dart:ui`, which means they're useful for Flutter apps. | |||
| Import | |||
There was a problem hiding this comment.
The entire "Import" section, including the excerpt, can be removed; the installation tab on pub.dev has that information now, so we are removing it from READMEs.
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| // #docregion Import |
There was a problem hiding this comment.
And then these can be removed as well.
|
auto label is removed for flutter/packages/5478, due to - The status or check suite Linux_android android_device_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
flutter/packages@b5958e2...1151191 2023-12-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.8 to 3.22.11 (flutter/packages#5674) 2023-12-13 ditman@gmail.com [ci][web] Ignore always_specify_types for JSArray. (flutter/packages#5669) 2023-12-13 mikemcguiness@protonmail.com [tool] Add support for `.java`, `.gradle`, `.sh`, and `.m` files� (flutter/packages#5567) 2023-12-13 ditman@gmail.com [google_sign_in] Update (web) example app. (flutter/packages#5634) 2023-12-13 34871572+gmackall@users.noreply.github.com [path_provider] De-flake getExternalStorageDirectories test (flutter/packages#5628) 2023-12-13 ditman@gmail.com [google_sign_in_web] Stop relying on framework internals. (flutter/packages#5660) 2023-12-13 43054281+camsim99@users.noreply.github.com [Android] Bump Gradle version to 7.6.3 (flutter/packages#5522) 2023-12-13 mikemcguiness@protonmail.com [google_sign_in] Adopt code excerpts in README (flutter/packages#5521) 2023-12-13 mikemcguiness@protonmail.com [css_colors] Adopt code excerpts in README (flutter/packages#5478) 2023-12-13 JeroenWeener@users.noreply.github.com [webview_flutter] Support for handling basic authentication requests (Android) (flutter/packages#5454) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Updates the README to use a compiled excerpt source for its example of importing and using
CSSColors.Part of flutter/flutter#102679
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.