[in_app_purchase] Add play country code api by reidbaker · Pull Request #5941 · flutter/packages

reidbaker · 2024-01-19T17:28:37Z

Initial add of country code, no tests
Add tests for getBillingConfig

fixes flutter/flutter/issues/141627

Hold merging on:

End to end manual test using https://codelabs.developers.google.com/codelabs/flutter-in-app-purchases#0

Pre-launch Checklist

… config test to return map not object

...se_android/android/src/main/java/io/flutter/plugins/inapppurchase/MethodCallHandlerImpl.java

gmackall · 2024-01-26T17:49:39Z

..._app_purchase/in_app_purchase_android/lib/src/in_app_purchase_android_platform_addition.dart

+  /// See: https://developer.android.com/reference/com/android/billingclient/api/BillingConfig
+  /// See: https://unicode.org/cldr/charts/latest/supplemental/territory_containment_un_m_49.html
+  Future<String> getBillingConfig() async {
+    return _billingClientManager.runWithClientNonRetryable(


Should this return a BillingConfigWrapper and then be also be retryable, as it returns a subclass of HasBillingResponse?

packages/packages/in_app_purchase/in_app_purchase_android/lib/src/billing_client_wrappers/billing_client_manager.dart

Line 92 in cbe8100

/// Designed only for operations that do not return a subclass

I wanted to keep the exposed api as small as possible so I thought the country code was the right level to expose. I didnt even think about if it should be retryable I just mirrored the other commands. Let me look at what that does and make a call.

I think this comment still applies

…utter/plugins#6459

…ain/java/io/flutter/plugins/inapppurchase/MethodCallHandlerImpl.java Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>

…i to getCountryCode

reidbaker · 2024-01-29T16:37:50Z

Without a correctly setup play store billing setup I was able to manually verify that I could get the country code of my personal account. I have not verified an account in a different country but the defaults are all empty string so I think that is a reasonable validation.

…le leaving instructions for how to test

reidbaker · 2024-01-29T16:42:29Z

Fixing readme validation that failed on previous content.
https://github.com/flutter/packages/blob/main/script/tool/lib/src/readme_check_command.dart

...purchase/in_app_purchase_android/lib/src/billing_client_wrappers/billing_client_wrapper.dart

packages/in_app_purchase/in_app_purchase_android/CHANGELOG.md

packages/in_app_purchase/in_app_purchase_android/example/README.md

gmackall · 2024-01-30T18:34:04Z

..._app_purchase/in_app_purchase_android/lib/src/in_app_purchase_android_platform_addition.dart

+  /// See: https://developer.android.com/reference/com/android/billingclient/api/BillingConfig
+  /// See: https://unicode.org/cldr/charts/latest/supplemental/territory_containment_un_m_49.html
+  Future<String> getBillingConfig() async {
+    return _billingClientManager.runWithClientNonRetryable(


I think this comment still applies

..._app_purchase/in_app_purchase_android/lib/src/in_app_purchase_android_platform_addition.dart

packages/in_app_purchase/in_app_purchase_storekit/example/README.md

gmackall

LGTM outside of the format/analyze failures!

…#5941)

flutter/packages@5b48c44...d37fb0a 2024-02-02 32242716+ricardoamador@users.noreply.github.com Add a link the different possible Android virtual device configs (flutter/packages#6033) 2024-02-01 32242716+ricardoamador@users.noreply.github.com Update the emulator versions and expose cipd. (flutter/packages#6025) 2024-02-01 stuartmorgan@google.com [tool] Add details to missing gradle coverage error (flutter/packages#6029) 2024-02-01 stuartmorgan@google.com [file_selector] Fix comment typo (flutter/packages#6027) 2024-02-01 43054281+camsim99@users.noreply.github.com [camerax] Change `buildPreview` to return `Texture` versus `FutureBuilder` (flutter/packages#6021) 2024-02-01 engine-flutter-autoroll@skia.org Manual roll Flutter from c65ab4d to e02e207 (38 revisions) (flutter/packages#6028) 2024-02-01 engine-flutter-autoroll@skia.org Manual roll Flutter from 75a2e5b to c65ab4d (22 revisions) (flutter/packages#6026) 2024-02-01 engine-flutter-autoroll@skia.org Roll Flutter from ace9181 to 75a2e5b (16 revisions) (flutter/packages#6017) 2024-02-01 JeroenWeener@users.noreply.github.com [webview_flutter] Support for handling basic authentication requests (flutter/packages#5727) 2024-01-31 stuartmorgan@google.com [tool] Extend `flutter test` workaround to other desktops (flutter/packages#6024) 2024-01-31 katelovett@google.com [two_dimensional_scrollables] Merged cells for TableView (flutter/packages#5917) 2024-01-31 tessertaha@gmail.com [rfw] Restore RFW to 100% coverage after `ButtonBar` update (flutter/packages#6020) 2024-01-31 louisehsu@google.com [in_app_purchase] Convert storefront(), transactions(), canMakePayment(), and addPayment() to pigeon (flutter/packages#5910) 2024-01-31 reidbaker@google.com [in_app_purchase] Add play country code api (flutter/packages#5941) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

reidbaker added 2 commits January 19, 2024 11:53

Intial add of country code, no tests

5be7c0a

Add tests for getBillingConfig

5d6f1cc

github-actions bot added p: in_app_purchase platform-android labels Jan 19, 2024

reidbaker added 11 commits January 19, 2024 14:39

Formating

e19b644

Manipulate data in translator class instead of impl

3f5a4e3

Add dart side code to call getBillingConfig and conversion tests

337a7d7

Correct null test to include empty country code, fix non null billing…

99af529

… config test to return map not object

move buildBillingConfigMap to the class that uses it

fdc42cd

Merge branch 'main' into i141627-country-code-api

88ccd2a

Write documentation and remove todos, remove unused import

036e2f2

Analyzer warnings

91950f3

Merge branch 'main' into i141627-country-code-api

7d4af42

java format warnings

5cd0acb

Version code change

894473c

reidbaker marked this pull request as ready for review January 25, 2024 20:27

reidbaker requested a review from gmackall as a code owner January 25, 2024 20:27

gmackall reviewed Jan 26, 2024

View reviewed changes

Restore in app purchase instructions in example readme from bad PR fl…

e33f22c

…utter/plugins#6459

reidbaker requested a review from LouiseHsu as a code owner January 26, 2024 17:58

github-actions bot added platform-ios platform-macos labels Jan 26, 2024

reidbaker and others added 2 commits January 26, 2024 13:21

Update packages/in_app_purchase/in_app_purchase_android/android/src/m…

1dc004b

…ain/java/io/flutter/plugins/inapppurchase/MethodCallHandlerImpl.java Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>

Add example app code that shows country code in UI rename addition ap…

319ffe7

…i to getCountryCode

Remove "Demonstrates how to use" verbiage since that is confusing whi…

28e95ad

…le leaving instructions for how to test

Merge branch 'main' into i141627-country-code-api

3c263a8

reidbaker requested a review from stuartmorgan-g January 30, 2024 16:02

reidbaker added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Jan 30, 2024

mossmana reviewed Jan 30, 2024

View reviewed changes

...purchase/in_app_purchase_android/lib/src/billing_client_wrappers/billing_client_wrapper.dart Show resolved Hide resolved

reidbaker requested a review from jmagman January 30, 2024 18:29

gmackall reviewed Jan 30, 2024

View reviewed changes

jmagman reviewed Jan 30, 2024

View reviewed changes

packages/in_app_purchase/in_app_purchase_storekit/example/README.md Outdated Show resolved Hide resolved

packages/in_app_purchase/in_app_purchase_storekit/example/README.md Outdated Show resolved Hide resolved

Remove changes to ios readme

d7934fc

github-actions bot removed platform-ios platform-macos labels Jan 30, 2024

reidbaker added 4 commits January 30, 2024 15:00

Readme link to signing docs and changelog verbiage update

5252d6e

Restore getCountryCode tests

5e363fc

Use run with client since BillingConfigWrapper uses a billing result

62477c4

Merge branch 'main' into i141627-country-code-api

a514dc1

gmackall approved these changes Jan 30, 2024

View reviewed changes

Use run with client since BillingConfigWrapper uses a billing result

f047aac

reidbaker added autosubmit Merge PR when tree becomes green via auto submit App and removed override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Jan 31, 2024

auto-submit bot merged commit 7b1ae1f into flutter:main Jan 31, 2024

reidbaker deleted the i141627-country-code-api branch January 31, 2024 15:29

engine-flutter-autoroll mentioned this pull request Feb 1, 2024

Roll Packages from 5b48c446976f to 013763dd574e (6 revisions) flutter/flutter#142710

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 1, 2024

7b1ae1f [in_app_purchase] Add play country code api (flutter/packages…

f0cbbd0

…#5941)

engine-flutter-autoroll mentioned this pull request Feb 1, 2024

Roll Packages from 5b48c446976f to be4dd938acc3 (7 revisions) flutter/flutter#142715

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 1, 2024

7b1ae1f [in_app_purchase] Add play country code api (flutter/packages…

d003a92

…#5941)

engine-flutter-autoroll mentioned this pull request Feb 1, 2024

Roll Packages from 5b48c446976f to aee1980899fc (8 revisions) flutter/flutter#142718

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 1, 2024

7b1ae1f [in_app_purchase] Add play country code api (flutter/packages…

18f1181

…#5941)

engine-flutter-autoroll mentioned this pull request Feb 2, 2024

Roll Packages from 5b48c446976f to 0f677d370a1f (13 revisions) flutter/flutter#142805

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 2, 2024

7b1ae1f [in_app_purchase] Add play country code api (flutter/packages…

1ad7cf1

…#5941)

engine-flutter-autoroll mentioned this pull request Feb 2, 2024

Roll Packages from 5b48c446976f to d37fb0a716e7 (14 revisions) flutter/flutter#142812

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 2, 2024

7b1ae1f [in_app_purchase] Add play country code api (flutter/packages…

acb4b10

…#5941)

reidbaker mentioned this pull request Feb 19, 2024

[in_app_purchase_android] Add UserChoiceBilling mode. #6162

Merged

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[in_app_purchase] Add play country code api#5941

[in_app_purchase] Add play country code api#5941
auto-submit[bot] merged 25 commits intoflutter:mainfrom
reidbaker:i141627-country-code-api

reidbaker commented Jan 19, 2024 •

edited

Loading

Uh oh!

Uh oh!

gmackall Jan 26, 2024

Uh oh!

reidbaker Jan 26, 2024

Uh oh!

gmackall Jan 30, 2024

Uh oh!

reidbaker commented Jan 29, 2024

Uh oh!

reidbaker commented Jan 29, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gmackall Jan 30, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gmackall left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

reidbaker commented Jan 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Uh oh!

gmackall Jan 26, 2024

Choose a reason for hiding this comment

Uh oh!

reidbaker Jan 26, 2024

Choose a reason for hiding this comment

Uh oh!

gmackall Jan 30, 2024

Choose a reason for hiding this comment

Uh oh!

reidbaker commented Jan 29, 2024

Uh oh!

reidbaker commented Jan 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gmackall Jan 30, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gmackall left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

reidbaker commented Jan 19, 2024 •

edited

Loading

reidbaker commented Jan 29, 2024 •

edited

Loading