[webview_flutter] Support for handling basic authentication requests (Platform Interface)#5362
Merged
auto-submit[bot] merged 48 commits intoflutter:mainfrom Nov 20, 2023
Conversation
…/packages into webview-auth-request
…b/src/types/http_auth_request.dart
…s into webview-auth-request
Contributor
Author
|
@stuartmorgan thank you for noticing. Turns out that new files are not removed when checking out the |
Collaborator
Oh, right 🤦🏻 Sorry about that, apparently I haven't run into the new files case recently so I forgot the workflow I described wouldn't handle that. |
bparrishMines
approved these changes
Nov 17, 2023
Contributor
bparrishMines
left a comment
There was a problem hiding this comment.
LGTM with a few nits
cc @stuartmorgan for secondary review
...ges/webview_flutter/webview_flutter_platform_interface/lib/src/types/webview_credential.dart
Show resolved
Hide resolved
...ages/webview_flutter/webview_flutter_platform_interface/lib/src/types/http_auth_request.dart
Outdated
Show resolved
Hide resolved
...ages/webview_flutter/webview_flutter_platform_interface/lib/src/types/http_auth_request.dart
Outdated
Show resolved
Hide resolved
| }); | ||
|
|
||
| test( | ||
| 'Default implementation of setOnReceiveHttpAuthRequest should throw unimplemented error', |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| 'Default implementation of setOnReceiveHttpAuthRequest should throw unimplemented error', | |
| 'Default implementation of setOnHttpAuthRequest should throw unimplemented error', |
…b/src/types/webview_credential.dart Co-authored-by: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com>
…b/src/types/http_auth_request.dart Co-authored-by: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com>
…b/src/types/http_auth_request.dart Co-authored-by: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com>
…hub.com/andreisas06/packages into webview-auth-request-platform-interface
Contributor
Author
|
Thanks @bparrishMines, I updated the branch based on your comments. |
stuartmorgan-g
approved these changes
Nov 19, 2023
Collaborator
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM with one question.
| sdk: flutter | ||
| meta: ^1.7.0 | ||
| plugin_platform_interface: ^2.1.0 | ||
| plugin_platform_interface: ^2.1.6 |
Collaborator
There was a problem hiding this comment.
Why is this changing? I don't think anything changed in that version that we could be depending on.
Collaborator
|
Overriding the out-of-date tree check; the dashboard is for some reason showing that run 490 is the last run of the failing test, but GitHub UI is correctly registering run 491 which is a re-run that passed. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 20, 2023
…equests (Platform Interface) (flutter/packages#5362)
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 20, 2023
flutter/packages@07b4b29...c5443ad 2023-11-20 JeroenWeener@users.noreply.github.com [webview_flutter] Support for handling basic authentication requests (Platform Interface) (flutter/packages#5362) 2023-11-18 engine-flutter-autoroll@skia.org Roll Flutter from 53a57ad to 6cf9ab0 (31 revisions) (flutter/packages#5426) 2023-11-18 kevmoo@users.noreply.github.com [shared_preferences_web] migrate to pkg:web (flutter/packages#5414) 2023-11-18 stuartmorgan@google.com [ci] Roll minimum allowable Flutter to 3.10 (flutter/packages#5425) 2023-11-18 43054281+camsim99@users.noreply.github.com [path_provider_android] Run tests on AVDs running Android 34 (flutter/packages#5222) 2023-11-17 tarrinneal@gmail.com [pigeon] isEnum, isClass, fix swift casting, default values, optional method arguments, named method arguments (flutter/packages#5355) 2023-11-17 stuartmorgan@google.com [plugin_platform_interface] Switch mixin to `mixin class` (flutter/packages#5420) 2023-11-17 stuartmorgan@google.com [go_router] Fixes use of `Iterable` (flutter/packages#5421) 2023-11-17 stuartmorgan@google.com [pigeon] Adds `analyzer` 6.x compatibility (flutter/packages#5418) 2023-11-17 stuartmorgan@google.com Update release step to 3.16 (flutter/packages#5416) 2023-11-17 kevmoo@users.noreply.github.com [file_selector_web] migrate to pkg:web (flutter/packages#5413) 2023-11-16 stuartmorgan@google.com [video_player] Improve macOS frame management (flutter/packages#5078) 2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter from e8c2bb1 to 53a57ad (39 revisions) (flutter/packages#5412) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
Closed
12 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
…5727) ## Description This pull request exposes the Android and iOS HTTP Basic Authentication feature to users of the `webview_flutter` plugin. It is the final PR in a sequence of PRs. Previous PRs are #5362, #5454 and #5455. Issues fixed by PR: Closes flutter/flutter#83556
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the platform interface implementation for basic http authentication.
This PR is part of a series of PRs that aim to close flutter/flutter#83556.
The PR that contains all changes can be found at #4140.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).