[go_router] adds ability to dynamically update routing table.#5079
Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom Oct 18, 2023
Merged
[go_router] adds ability to dynamically update routing table.#5079auto-submit[bot] merged 1 commit intoflutter:mainfrom
auto-submit[bot] merged 1 commit intoflutter:mainfrom
Conversation
Contributor
Author
|
will write a breaking change doc later |
hannah-hyj
approved these changes
Oct 9, 2023
Contributor
Author
There was a problem hiding this comment.
Previous there are no use case that the imperative route match can be equal because all the completers in them are different. so I optimize it away to use identity hash (otherwise it would use the super == which will return incorrect result).
Now that the RouteMatchList will be reparsed after the routing config changes. The ImperativeRouteMatch will reuse its completer when them are recreated, so there can be cases where equality is possible.
f75f48d to
3368bb6
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 19, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 19, 2023
flutter/packages@14aa69e...09c6b11 2023-10-19 engine-flutter-autoroll@skia.org Manual roll Flutter from 6eea6e2 to 189196d (44 revisions) (flutter/packages#5178) 2023-10-18 47866232+chunhtai@users.noreply.github.com [go_router] adds ability to dynamically update routing table. (flutter/packages#5079) 2023-10-18 devoncarew@google.com [flutter_lints] rev flutter_lints to 3.0; increase dep on package:lints (flutter/packages#5177) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 2f708eb to 6c4930c (1 revision) (flutter/packages#5173) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Closed
12 tasks
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes flutter/flutter#136005
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.