Skip to content

[go_router_builder] Adds name parameter to TypedGoRoute and supports its generation.#3665

Merged
auto-submit[bot] merged 26 commits intoflutter:mainfrom
App-and-Up:feature/add-name
May 10, 2023
Merged

[go_router_builder] Adds name parameter to TypedGoRoute and supports its generation.#3665
auto-submit[bot] merged 26 commits intoflutter:mainfrom
App-and-Up:feature/add-name

Conversation

@dancamdev
Copy link
Contributor

@dancamdev dancamdev commented Apr 8, 2023 •
edited
Loading

This PR allows for generating TypedGoRoutes by defining a custom name and forwarding it to the underlying GoRoute this is needed when working with Analytics services such as Google analytics that use the name to log the page in their systems.

Fixes #120102

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@dancamdev
Copy link
Contributor Author

dancamdev commented Apr 8, 2023

I'd need a hand here, CI is failing because go_router_builder is relying on the upstream go_router version, @chunhtai would it be ok to rely on the local go_router instead? What is the recommended way to do this otherwise?

@dancamdev dancamdev marked this pull request as ready for review April 8, 2023 14:49
@dancamdev dancamdev requested a review from chunhtai as a code owner April 8, 2023 14:49
@chunhtai
Copy link
Contributor

chunhtai commented Apr 10, 2023

You need to separate out two pr, one for go_router and one for go_router_builder. The go_router one need to be merged first before the ci in go_router_builder can pass

chunhtai
chunhtai requested changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please separate out two prs

@dancamdev dancamdev mentioned this pull request Apr 13, 2023
Merged
11 tasks
@dancamdev dancamdev changed the title [go_router] [go_router_builder] Adds name parameter to TypedGoRoute and supports its generation. [go_router_builder] Adds name parameter to TypedGoRoute and supports its generation. Apr 13, 2023
@dancamdev
Copy link
Contributor Author

dancamdev commented Apr 13, 2023

Needs #3702 to be merged before tests can pass and this pr can be merged.

auto-submit bot pushed a commit that referenced this pull request Apr 24, 2023
@dancamdev
[go_router] Adds name to TypedGoRoute (#3702)
5dad90c 
This PR is required for [#3665](#3665) to work and be merged.

It should allow for generating `TypedGoRoutes` by defining a custom name and forwarding it to the underlying GoRoute. This is needed when working with Analytics services such as Google analytics that use the `RouteSettings.name` to log the page in their systems.

*List which issues are fixed by this PR. You must list at least one issue.*
[#120102](flutter/flutter#120102)
@chunhtai
Copy link
Contributor

chunhtai commented Apr 27, 2023

Hi @dancamdev, what's the status of this pr?

@dancamdev @Michele-x98
fixes build_runner error
ec70a3e 
Co-authored-by: MicheleBenedetti <Michele-x98@users.noreply.github.com>
@chunhtai chunhtai mentioned this pull request May 4, 2023
Closed
2 tasks
chunhtai
chunhtai reviewed May 5, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch seems old, can you rebased off latest main?

@dancamdev dancamdev requested a review from chunhtai May 8, 2023 09:57
chunhtai
chunhtai approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai requested a review from hannah-hyj May 9, 2023 16:47
hannah-hyj
hannah-hyj approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@hannah-hyj hannah-hyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label May 10, 2023
@auto-submit auto-submit bot merged commit 6328cfb into flutter:main May 10, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 10, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2023
@engine-flutter-autoroll
6328cfb [go_router_builder] Adds name parameter to TypedGoRoute and s…
285eea7 
…upports its generation. (flutter/packages#3665)
@reidbaker reidbaker mentioned this pull request May 12, 2023
Merged
11 tasks
camsim99 pushed a commit to flutter/flutter that referenced this pull request May 12, 2023
@engine-flutter-autoroll
Roll Packages from 0167d83 to 6328cfb (2 revisions) (#126442)
9c72f5a 
flutter/packages@0167d83...6328cfb

2023-05-10 43640732+dancamdev@users.noreply.github.com
[go_router_builder] Adds name parameter to TypedGoRoute and supports its
generation. (flutter/packages#3665)
2023-05-10 stuartmorgan@google.com [various] Remove iOS 9 references
(flutter/packages#3948)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert
to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@engine-flutter-autoroll
Roll Packages from 0167d83 to 6328cfb (2 revisions) (flutter#126442)
3e6dfdb 
flutter/packages@0167d83...6328cfb

2023-05-10 43640732+dancamdev@users.noreply.github.com
[go_router_builder] Adds name parameter to TypedGoRoute and supports its
generation. (flutter/packages#3665)
2023-05-10 stuartmorgan@google.com [various] Remove iOS 9 references
(flutter/packages#3948)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert
to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
Merged
Closed
Merged
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@dancamdev @nploi
[go_router] Adds name to TypedGoRoute (flutter#3702)
b47ddbb 
This PR is required for [flutter#3665](flutter#3665) to work and be merged.

It should allow for generating `TypedGoRoutes` by defining a custom name and forwarding it to the underlying GoRoute. This is needed when working with Analytics services such as Google analytics that use the `RouteSettings.name` to log the page in their systems.

*List which issues are fixed by this PR. You must list at least one issue.*
[#120102](flutter/flutter#120102)
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@dancamdev @nploi
[go_router_builder] Adds name parameter to TypedGoRoute and supports …
507a1db 
…its generation. (flutter#3665)

This PR allows for generating `TypedGoRoutes` by defining a custom name and forwarding it to the underlying `GoRoute` this is needed when working with Analytics services such as Google analytics that use the name to log the page in their systems.

Fixes [#120102](flutter/flutter#120102)
@dancamdev dancamdev mentioned this pull request Jul 20, 2023
Merged
11 tasks
auto-submit bot pushed a commit that referenced this pull request Jul 21, 2023
@dancamdev
Adding myself and Michele to AUTHORS (#4527)
3b2b497 
As per title, because of contributing to the following PRs:

[#3702](#3702)
[#3665](#3665)
[#3627](#3627)
@reidbaker reidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
@reidbaker reidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunhtai chunhtai chunhtai approved these changes

@hannah-hyj hannah-hyj hannah-hyj approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: go_router_builder

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[go_router] Typed GoRoutes don't have RouteSettings.name, resulting in blank Analytics screen names

4 participants

@dancamdev @chunhtai @hannah-hyj @Michele-x98