[go_router_builder] Adds support for required $extra parameter#3627
[go_router_builder] Adds support for required $extra parameter#3627auto-submit[bot] merged 11 commits intoflutter:mainfrom
Conversation
|
Hi @Hangyujin Can you take a look at this PR? |
|
Fixed the merge conflicts with |
|
Thanks @Michele-x98 for the fix! |
chunhtai
left a comment
There was a problem hiding this comment.
LGTM, once the ci failure are fixed
|
@chunhtai should be good to go |
|
It looks like there are still some failures |
Due to the following:
But this is a CI issue because If that's not it, mind pointing me to the issue you're seeing? Thanks |
|
@chunhtai Got it working! |
…er#3627) [go_router_builder] Adds support for required $extra parameter
This PR includes support for having type-safe non-nullable
$extraparameters when working withTypedGoRoutes. Optional$extrais still supported so this isn't a breaking change.List which issues are fixed by this PR. You must list at least one issue.
#117261
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.