Fix warning in flutter created project ("package attribute is deprecated" in AndroidManifest)#123426
Fix warning in flutter created project ("package attribute is deprecated" in AndroidManifest)#123426auto-submit[bot] merged 4 commits intoflutter:masterfrom bartekpacia:fix/android_gradle_namespace
flutter created project ("package attribute is deprecated" in AndroidManifest)#123426Conversation
* add `namespace` to app/build.gradle templates * add `namespace` to AndroidManifest.xml templates
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@reidbaker Can someone with Android expertise take a look at this, please? |
|
Does this also fix #123636 (which I filed before seeing this PR) |
|
auto label is removed for flutter/flutter, pr: 123426, due to This PR has not met approval requirements for merging. You have project association CONTRIBUTOR and need 1 more review(s) in order to merge this PR.
|
|
auto label is removed for flutter/flutter, pr: 123426, due to Validations Fail. |
There was a problem hiding this comment.
LGTM, thanks!
It would be good to make a migration for this, too, so that Flutter developers don't get this warning in existing apps. But that would have to come after upgrading Gradle, #122376. (Or else be conditional on the Gradle version, but seems simplest to just sequence it after upgrading Gradle.)
edit: Oh, more to the point: it would have to come after upgrading AGP (to at least 7.3, where this "namespace" feature was introduced). But that in turn will require upgrading Gradle.
No — this PR doesn't affect what AGP version (or Gradle version) is used. It just migrates off of using a deprecated bit of the API of AGP, to a new API that was introduced in a recent AGP. |
…is deprecated" in AndroidManifest) (flutter/flutter#123426)
…is deprecated" in AndroidManifest) (flutter/flutter#123426)
…is deprecated" in AndroidManifest) (flutter/flutter#123426)
…is deprecated" in AndroidManifest) (flutter/flutter#123426)
…is deprecated" in AndroidManifest) (flutter/flutter#123426)
…is deprecated" in AndroidManifest) (flutter/flutter#123426)
…is deprecated" in AndroidManifest) (flutter/flutter#123426)
…is deprecated" in AndroidManifest) (flutter/flutter#123426)
…is deprecated" in AndroidManifest) (flutter/flutter#123426)
…is deprecated" in AndroidManifest) (flutter/flutter#123426)
…is deprecated" in AndroidManifest) (flutter/flutter#123426)
…is deprecated" in AndroidManifest) (flutter/flutter#123426)
…is deprecated" in AndroidManifest) (flutter/flutter#123426)
…is deprecated" in AndroidManifest) (flutter/flutter#123426)
…is deprecated" in AndroidManifest) (flutter/flutter#123426)
…is deprecated" in AndroidManifest) (flutter/flutter#123426)
…is deprecated" in AndroidManifest) (flutter/flutter#123426)
…is deprecated" in AndroidManifest) (flutter/flutter#123426)
…is deprecated" in AndroidManifest) (flutter/flutter#123426)
…is deprecated" in AndroidManifest) (flutter/flutter#123426)
…is deprecated" in AndroidManifest) (flutter/flutter#123426)
This PR resolves #123302
Learn more:
Pre-launch Checklist
///).