Update getGradleVersion to ignore commented out lines#124260
Merged
reidbaker merged 2 commits intoflutter:masterfrom Apr 7, 2023
reidbaker:i123917-commented-out-lines-gradlew
Merged
Update getGradleVersion to ignore commented out lines#124260reidbaker merged 2 commits intoflutter:masterfrom reidbaker:i123917-commented-out-lines-gradlew
reidbaker merged 2 commits intoflutter:masterfrom
reidbaker:i123917-commented-out-lines-gradlew
Conversation
gmackall
reviewed
Apr 5, 2023
| // '^\s*' protects against commented out lines. | ||
| final RegExp distributionUrlRegex = | ||
| RegExp(r'distributionUrl\s?=\s?.*\.zip'); | ||
| RegExp(r'^\s*distributionUrl\s?=\s?.*\.zip', multiLine: true); |
Member
There was a problem hiding this comment.
Question (but nit even if yes), do we want to match even if there are multiple spaces around the equals? e.g.
RegExp(r'^\s*distributionUrl\s*=\s*.*\.zip', multiLine: true)
Contributor
Author
There was a problem hiding this comment.
yes I will update this.
gmackall
approved these changes
Apr 6, 2023
Member
gmackall
left a comment
There was a problem hiding this comment.
LGTM other than the mentioned nit
Contributor
Author
|
Frob testing is broken on something unrelated. Merging anyway. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 8, 2023
exaby73
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Apr 17, 2023
flutter#123917 Missed feedback from flutter#123916 - Handle commented out lines in gradle-wrapper.properties This is 1 of 2 prs to handle missed feedback. Formatting will be done in the second whereas this one captures a weakness missed in the last pr. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#123917
Missed feedback from #123916
This is 1 of 2 prs to handle missed feedback. Formatting will be done in the second whereas this one captures a weakness missed in the last pr.
Pre-launch Checklist
///).