This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
yjbanov
reviewed
Nov 17, 2022
harryterkelsen
suggested changes
Nov 17, 2022
Contributor
harryterkelsen
left a comment
There was a problem hiding this comment.
LGTM if Yegor's suggested changes are made
0385528 to
09f3939
Compare
Contributor
|
test-exempt: removing code |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 17, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 17, 2022
* ac874d6 [Multiwindow] Renderers receive view IDs as argument (flutter/engine#36593) * bc86c1f Roll Skia from d90917a1da6b to 89f8ba6f749d (10 revisions) (flutter/engine#37723) * dd12a40 delete fontface polyfill (flutter/engine#37652) * 1e1a4ab Add call to Dart_NotifyDestroyed when the flutter view is destroyed. (flutter/engine#37539)
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…5592) * ac874d6 [Multiwindow] Renderers receive view IDs as argument (flutter/engine#36593) * bc86c1f Roll Skia from d90917a1da6b to 89f8ba6f749d (10 revisions) (flutter/engine#37723) * dd12a40 delete fontface polyfill (flutter/engine#37652) * 1e1a4ab Add call to Dart_NotifyDestroyed when the flutter view is destroyed. (flutter/engine#37539)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…5592) * ac874d6 [Multiwindow] Renderers receive view IDs as argument (flutter/engine#36593) * bc86c1f Roll Skia from d90917a1da6b to 89f8ba6f749d (10 revisions) (flutter/engine#37723) * dd12a40 delete fontface polyfill (flutter/engine#37652) * 1e1a4ab Add call to Dart_NotifyDestroyed when the flutter view is destroyed. (flutter/engine#37539)
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
support or IE11 and old Edge has been removed. Removed FontFace Polyfills as well
fixes: flutter/flutter#115013
Pre-launch Checklist
///).