This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Multiwindow] Renderers receive view IDs as argument#36593
Merged
auto-submit[bot] merged 22 commits intoflutter:mainfrom Nov 17, 2022
Merged
[Multiwindow] Renderers receive view IDs as argument#36593auto-submit[bot] merged 22 commits intoflutter:mainfrom
auto-submit[bot] merged 22 commits intoflutter:mainfrom
Conversation
iskakaushik
reviewed
Nov 11, 2022
| - (FlutterMetalTexture)createTextureForView:(uint64_t)viewId size:(CGSize)size { | ||
| FlutterView* view = [_viewProvider getView:viewId]; | ||
| if (view == nil) { | ||
| FML_LOG(WARNING) << "Can't create texture on a non-existent view."; |
Contributor
There was a problem hiding this comment.
Should this be an error? When can this happen?
Contributor
Author
There was a problem hiding this comment.
When the caller sends a view ID that the engine does not recognize. When the engine is run as a whole, this should not happen.
(Yes, the same as #36392 (comment) )
Member
There was a problem hiding this comment.
If this shouldn't happen, is there any reason not to make it an assertion?
Contributor
Author
There was a problem hiding this comment.
Nope. I've converted it to an assertion.
| - (void)setViewController:(FlutterViewController*)controller { | ||
| if (_viewController != controller) { | ||
| _viewController = controller; | ||
| [_renderer setFlutterView:controller.flutterView]; |
Contributor
There was a problem hiding this comment.
Where is the view registered with the view provider?
Contributor
Author
There was a problem hiding this comment.
Any other places. The view provider is just a protocol/facade over other classes, and will have other methods to register views, which is not shown as a view provider.
In the real application the view provider is macos/FlutterEngine, which is the source-of-truth of the set of views.
shell/platform/darwin/macos/framework/Source/FlutterMetalRendererTest.mm
Outdated
Show resolved
Hide resolved
fbc4210 to
8e7c29e
Compare
Contributor
Author
|
I've fixed all the comments. Thanks for pointing out |
iskakaushik
approved these changes
Nov 17, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 17, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 17, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 17, 2022
* ac874d6 [Multiwindow] Renderers receive view IDs as argument (flutter/engine#36593) * bc86c1f Roll Skia from d90917a1da6b to 89f8ba6f749d (10 revisions) (flutter/engine#37723) * dd12a40 delete fontface polyfill (flutter/engine#37652) * 1e1a4ab Add call to Dart_NotifyDestroyed when the flutter view is destroyed. (flutter/engine#37539)
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…5592) * ac874d6 [Multiwindow] Renderers receive view IDs as argument (flutter/engine#36593) * bc86c1f Roll Skia from d90917a1da6b to 89f8ba6f749d (10 revisions) (flutter/engine#37723) * dd12a40 delete fontface polyfill (flutter/engine#37652) * 1e1a4ab Add call to Dart_NotifyDestroyed when the flutter view is destroyed. (flutter/engine#37539)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…5592) * ac874d6 [Multiwindow] Renderers receive view IDs as argument (flutter/engine#36593) * bc86c1f Roll Skia from d90917a1da6b to 89f8ba6f749d (10 revisions) (flutter/engine#37723) * dd12a40 delete fontface polyfill (flutter/engine#37652) * 1e1a4ab Add call to Dart_NotifyDestroyed when the flutter view is destroyed. (flutter/engine#37539)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes
FlutterRendererso that it can no longer be assigned with a view, but instead the methods receive a view ID as an argument when called.Part of the multiwindow project (design doc): There can only be one renderer, since the renderer is created when the engine is initialized. Therefore, the renderer must be able to handle multiple views.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.