Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Specify the min simulator version. #36809

Merged
auto-submit merged 1 commit into from
Oct 17, 2022
Merged

[Impeller] Specify the min simulator version. #36809

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions impeller/tools/build_metal_library.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,15 +100,19 @@ def main():
'-Oz',
# Allow aggressive, lossy floating-point optimizations.
'-ffast-math',
# limiting to ios-metal1.2 disables shader debug symbols, only
# enabling these in optimize mode.
# see https://github.com/flutter/flutter/issues/106066
'--std=ios-metal1.2',
]
if args.platform == 'ios':
# limiting to ios-metal1.2 disables shader debug symbols, only
# enabling these in optimize mode.
# see https://github.com/flutter/flutter/issues/106066
command += [
'--std=ios-metal1.2',
'-mios-version-min=10.0',
Copy link
Member

@zanderso zanderso Oct 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also be 11.0?

Copy link
Contributor Author

@chinmaygarde chinmaygarde Oct 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, may I change it in a later patch though? It is unrelated to the sim fix.

Copy link
Contributor Author

@chinmaygarde chinmaygarde Oct 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also want to remove the workaround around optimizations that were making Xcode crashy. This script is looking a bit confusing now.

]
elif args.platform == 'ios-simulator':
command += [
'-miphonesimulator-version-min=11.0',
]
else:
command += [
# Embeds both sources and driver options in the output. This aids in
Expand Down