[Impeller] Specify the min simulator version.#36809
[Impeller] Specify the min simulator version.#36809auto-submit[bot] merged 1 commit intoflutter:mainfrom
Conversation
| # see https://github.com/flutter/flutter/issues/106066 | ||
| command += [ | ||
| '--std=ios-metal1.2', | ||
| '-mios-version-min=10.0', |
There was a problem hiding this comment.
Yeah, may I change it in a later patch though? It is unrelated to the sim fix.
There was a problem hiding this comment.
I also want to remove the workaround around optimizations that were making Xcode crashy. This script is looking a bit confusing now.
|
@zanderso I've tried to test this on hosts I have on hand but they were working before too. I am unable to remote into my desktop in the office that I am pretty sure will tickle the error. If you are able to test this fixes the error, I'd appreciate a sanity check. This builds and works just fine. |
zanderso
left a comment
There was a problem hiding this comment.
This fixes the issue for me locally, and the validation errors now no longer show up in the scenario test logs https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8800025623849152401/+/u/test:_Scenario_App_Integration_Tests/stdout?format=raw
Fixes flutter/flutter#113358